Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-1630] Enable automatic time range adjustments for standard sets of time filter predicates #1013

Open
Tracked by #1010
tlento opened this issue Jan 29, 2024 · 0 comments
Labels
Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync

Comments

@tlento
Copy link
Contributor

tlento commented Jan 29, 2024

We currently support time range adjustments when users pass in explicit start and end time values. These interfaces are only really exposed in the CLI, however, and are not available in, e.g., metric filter specifications in the YAML.

We have decided to allow some limited-scope detection of time range filter expressions across all input modes such that we can do the granularity and time-window adjustments on the filter spec pre-rendering, much as we do with the date/time literals passed in start_time/end_time, rather than via datetime function manipulation.

The current idea is to do a simple regex match to detect the most common filter expressions for setting a time range - i.e., one bounded by time literals - on a single time dimension (notably metric_time). This will allow users to trigger pushdown by doing fairly natural things like adding a single filter for `metric_time BETWEEN '2021-01-01' AND '2021-01-31'.

From SyncLinear.com | SL-1630

@tlento tlento changed the title Enable automatic time range adjustments for standard sets of time filter predicates [SL-1630] Enable automatic time range adjustments for standard sets of time filter predicates Jan 29, 2024
@tlento tlento added the Metricflow Gap Created by Linear-GitHub Sync label Jan 30, 2024
@tlento tlento added this to the v.13 milestone Jan 30, 2024
@tlento tlento added Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync Medium priority Created by Linear-GitHub Sync and removed Metricflow Gap Created by Linear-GitHub Sync labels Jan 30, 2024
@tlento tlento removed this from the v.13 milestone Jan 30, 2024
@tlento tlento added Metricflow Created by Linear-GitHub Sync and removed Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Feb 8, 2024
@tlento tlento added this to the Predicate Pushdown milestone Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant