Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SL-1346] [Bug] Filters specified on nested derived metrics are not properly applied #920

Closed
tlento opened this issue Dec 5, 2023 · 6 comments · Fixed by #919
Closed

[SL-1346] [Bug] Filters specified on nested derived metrics are not properly applied #920

tlento opened this issue Dec 5, 2023 · 6 comments · Fixed by #919
Assignees
@tlento
Labels
bug Something isn't working High priority Created by Linear-GitHub Sync Medium Created by Linear-GitHub Sync
Milestone
Spring Cleaning b...

Comments

@tlento
Copy link
Contributor

tlento commented Dec 5, 2023 •
edited

Under certain circumstances, filters aren’t applied in nested derived metrics. https://getdbt.slack.com/archives/C02CCBBBR1D/p1701795017142279

The issue here is that we do not render filters specified on a derived metric definition that has other filtered derived metrics defined as its inputs. See #919 for a test illustrating the rendering problem.

SL-1346
@tlento tlento added the bug Something isn't working label Dec 5, 2023
@tlento tlento self-assigned this Dec 5, 2023
@tlento tlento changed the title Filters specified on nested derived metrics are not properly applied [SL-1346] Filters specified on nested derived metrics are not properly applied Dec 5, 2023
@tlento tlento added High priority Created by Linear-GitHub Sync Medium Created by Linear-GitHub Sync labels Dec 5, 2023
@tlento tlento changed the title [SL-1346] Filters specified on nested derived metrics are not properly applied [SL-1346] [Bug] Filters specified on nested derived metrics are not properly applied Dec 7, 2023
@plypaul
Copy link
Contributor

plypaul commented Dec 21, 2023

It seems like this was fixed as a side effect of the dataflow plan updates in the group-by-item resolution PR. Mind regenerating your snapshots?

@marcodamore
Copy link
Collaborator

Pinged @tomkit.lento to double check whether this is fixed

@tlento tlento added Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Jan 18, 2024
@tlento
Copy link
Contributor Author

tlento commented Jan 18, 2024

Yes, I think this is fixed! I'll put up a PR with some added test cases and include a changelog entry indicating that this was fixed with 0.204.0

@marcodamore
Copy link
Collaborator

Sweeeet ty

@tlento tlento closed this as completed Jan 22, 2024
@tlento tlento linked a pull request Jan 26, 2024 that will close this issue
Add query rendering test for filters on nested derived metrics #919
Merged
@tlento
Copy link
Contributor Author

tlento commented Jan 26, 2024

Tests merged so this is doubly-done!

@marcodamore
Copy link
Collaborator

Yeehaw

@tlento tlento removed Metricflow Created by Linear-GitHub Sync Metricflow Gap Created by Linear-GitHub Sync labels Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlento tlento

Labels
bug Something isn't working High priority Created by Linear-GitHub Sync Medium Created by Linear-GitHub Sync
Projects
None yet
Milestone
Spring Cleaning but in January 🧹❄️
Development

Successfully merging a pull request may close this issue.

Add query rendering test for filters on nested derived metrics dbt-labs/metricflow
3 participants
@tlento @plypaul @marcodamore