Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINSIGSTKSZ no longer a constant #21

Open
e-voro opened this issue Dec 30, 2022 · 5 comments · May be fixed by #23
Open

MINSIGSTKSZ no longer a constant #21

e-voro opened this issue Dec 30, 2022 · 5 comments · May be fixed by #23

Comments

@e-voro
Copy link

e-voro commented Dec 30, 2022

Upgrading Ubuntu 20 up to Ubuntu 22 caused the issue described here Catch2/issues/2421.

@e-voro
Copy link
Author

e-voro commented Dec 30, 2022

Hello! I have prepared the solution. May I pull a branch? May I create a pull request?

@caneraltinbasak
Copy link

Yes please. Happy to merge if you have a fix.

@e-voro
Copy link
Author

e-voro commented Jan 11, 2023

@caneraltinbasak Caner, unfortunately I can't push the branch for meshing one to the pull request. Could you give me some access?

dbus-asio$ git push -u origin 21-MINSIGSTKSZ-no-longer-a-constant 
ERROR: Permission to dbus-asio/dbus-asio.git denied to e-voro.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@mikecrowe
Copy link
Contributor

mikecrowe commented Jan 15, 2023

I believe that the GitHub workflow is that you create your own fork of the repository under your GitHub account and then when you push to a branch there it will offer you the chance to submit a pull request to the dbus-asio repository.

@e-voro
Copy link
Author

e-voro commented May 22, 2023

@mikecrowe , @caneraltinbasak , hello! Created fork and created pull request. Please, take a look. Hope it is useful for project! #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants