Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left position being incorrectly calculated #304

Open
RossLote opened this issue Apr 29, 2015 · 7 comments
Open

Left position being incorrectly calculated #304

RossLote opened this issue Apr 29, 2015 · 7 comments

Comments

@RossLote
Copy link

line 906 of pikaday.js:

left = left - width + field.offsetWidth;

is resulting in -711px.
I've commented that line out and it seems to be working perfectly.

@benjibee
Copy link

Hi @RossLote, is this possibly related to my issue?

@RossLote
Copy link
Author

@benjibee Yeah, It looks like the same problem.

@benjibee
Copy link

I can confirm that commenting out line :906 fixes the issue I was seeing.

@RossLote
Copy link
Author

Awesome. I haven't got to looking at what that block of code is supposed to do. I wonder if it's necessary?

@benjibee
Copy link

@RossLote not quite sure, and I don't honestly have the time to get into it at the moment.

Perhaps @dbushell or @rikkert could chime in on this?

@VisualBean
Copy link

I was also getting weird results on mobile devices - I added if
(left < 0) { left = 0; }
after
left = left - width + field.offsetWidth;
which helped

@deepure
Copy link

deepure commented May 6, 2015

I think this bug is caused by left value is different between hide and show.

#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants