Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata don't work #12

Closed
MarcosPer opened this issue Aug 20, 2017 · 5 comments
Closed

Metadata don't work #12

MarcosPer opened this issue Aug 20, 2017 · 5 comments
Labels

Comments

@MarcosPer
Copy link

I'm using this module and it works, it show player controls in https://github.com/azdyb/gnome-shell-extension-mpriscontrol and events are working but i can't send any metadata. I tried to update to node-dbus to 1.0.0 version following this https://github.com/Shouqun/node-dbus/blob/master/MIGRATING.md but it still failing.

How can i do for solve this?

This isn't problem of gnome shell because it works with other players. I tried in ubuntu 16.04 and ubuntu gnome 16.04 and linux mint without any successful result.

@emersion
Copy link
Collaborator

i can't send any metadata

What do you mean?

If possible, provide your source code and describe what happens and what is expected to happen.

@emersion emersion added the bug label Aug 24, 2017
@MarcosPer
Copy link
Author

MarcosPer commented Aug 28, 2017

For example when i use examples/player.js i see this in status bar

captura de pantalla de 2017-08-28 12-48-45

Events work great but i don't see any metadata info as title for example. But when i use other player i see metadata correctly so insn't problem of status bar

captura de pantalla de 2017-08-28 12-56-55

I think that is a problem of the way that dbus send metadata, but its only an suspicion but i didn't found any evidence of this.

The info is shown by this gnome extension https://extensions.gnome.org/extension/55/media-player-indicator/

Dbus Version: D-Bus Message Bus Daemon 1.10.6
Node Version: v4.2.6

Updating node to 6.x i get these errors of dbus executing player.js
Failed to encode dictionary
Failed to encode reply value
Failed to encode dictionary
Failed to encode reply value
Failed to encode dictionary
Failed to encode reply value
Failed to encode dictionary
Failed to encode reply value
Failed to encode dictionary
Failed to encode reply value
Now playing: Lolol - Adele - 21

@fcastilloec
Copy link

You shouldn't rely on the example because the art URL used is not working anymore and there's an error on the artist metadata.
Try again the example, and replace:

  • 'mpris:artUrl': https://upload.wikimedia.org/wikipedia/commons/thumb/7/7c/Adele_2016.jpg/800px-Adele_2016.jpg
  • 'xesam:artist': ['Adele']

Notice that the 'xesam:artist' is an array an not a string. Try both of this and the example should work.

@acrisci
Copy link
Member

acrisci commented Mar 5, 2019

I'm pretty sure this should work now with the dbus-next update.

@emersion
Copy link
Collaborator

emersion commented Mar 5, 2019

Yeah. I'm going to close this as the code has completely changed. Feel free to re-open if you can still reproduce.

@emersion emersion closed this as completed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants