Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle libmaxminddb #1

Closed
josh opened this issue Dec 20, 2014 · 3 comments
Closed

Bundle libmaxminddb #1

josh opened this issue Dec 20, 2014 · 3 comments

Comments

@josh
Copy link
Contributor

josh commented Dec 20, 2014

Hey @dbussink, question/idea. Is there any reason this gem can't bundle libmaxminddb instead of relying on it externally? Would it be ridiculously big?

This is 1 of 2 external gem libs used by github. And we're trying to get icu bundled for charlock_holmes brianmario/charlock_holmes#82.

wdyt?

/cc @brianmario

@dbussink
Copy link
Owner

It's not a huge library so that should be possible I think. What's the value / goal here? More isolated builds / independent gems?

@josh
Copy link
Contributor Author

josh commented Dec 22, 2014

Yeah, you won't need to have libmaxminddb installed. gem install geoip2_compat will pretty much always work.

@josh josh mentioned this issue Dec 22, 2014
6 tasks
@josh josh closed this as completed Dec 29, 2014
@Sami2a
Copy link

Sami2a commented Jan 5, 2015

require "mkmf"
extension_name = "geoip2_compat"

$LDFLAGS << " #{ENV['LDFLAGS']}"
$CFLAGS << " -std=c99 #{ENV['CFLAGS']}"

RbConfig::MAKEFILE_CONFIG['CC'] = ENV['CC'] if ENV['CC']

$defs << ' -DPACKAGE_VERSION="1.0.3"'

create_makefile("#{extension_name}/#{extension_name}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants