-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle libmaxminddb #1
Comments
It's not a huge library so that should be possible I think. What's the value / goal here? More isolated builds / independent gems? |
Yeah, you won't need to have |
require "mkmf" $LDFLAGS << " #{ENV['LDFLAGS']}" RbConfig::MAKEFILE_CONFIG['CC'] = ENV['CC'] if ENV['CC'] $defs << ' -DPACKAGE_VERSION="1.0.3"' create_makefile("#{extension_name}/#{extension_name}") |
Hey @dbussink, question/idea. Is there any reason this gem can't bundle
libmaxminddb
instead of relying on it externally? Would it be ridiculously big?This is 1 of 2 external gem libs used by github. And we're trying to get
icu
bundled forcharlock_holmes
brianmario/charlock_holmes#82.wdyt?
/cc @brianmario
The text was updated successfully, but these errors were encountered: