-
Notifications
You must be signed in to change notification settings - Fork 24
The popup in Choropleth doesn't work #22
Comments
Hi @ackuser, The same here ! |
Doesn't appear to work for the marker chart either. It looks like it's set up correctly but I don't know, maybe the clicks are getting through or something. |
Ok I made a quick test: setting |
Thanks for testing. I dug into it a little more, and it looks like the event handling is fine, but the issue is that On the demo page, it looks like there is a similar issue with the cluster marker: clicking a cluster causes zooming, which erases the popup. The popup works on a non-cluster (fully expanded) marker. Do you want to filter and show the popup at the same time? |
I haven't looked into how to implement this, but I suppose one or the other action could be triggered only when a modifier key is pressed. |
Hi @gordonwoodhull , |
I don’t understand the distinction. Either way you are enabling or disabling one of the actions based on what keys are pressed, right? |
Okay, I implemented @msimonin, please check if the documentation on LeafletBase is sufficient, and leave a comment here if it needs more explanation or doesn't work. I changed the demo to display popups only when the control key (command key on Macs) is pressed. |
I just tested and it's perfect ! |
In dc.leaflet version 0.2.3 for the Choropleth Chart the popup doesn't work or it doesn't get rendered. Am I wrong or it happens to anybody else? I will be happy to fix that but I would need some help.
Anyway, any help would be really appreciated
The text was updated successfully, but these errors were encountered: