Skip to content
This repository has been archived by the owner on Dec 30, 2023. It is now read-only.

Issue while importing module #28

Closed
doshisunny opened this issue May 4, 2017 · 3 comments
Closed

Issue while importing module #28

doshisunny opened this issue May 4, 2017 · 3 comments

Comments

@doshisunny
Copy link

doshisunny commented May 4, 2017

I am having issue with importing dc.leaflet while importing it.
const dcLeaflet = require('dc.leaflet');
gives me error unable to resolve path module
Currently I am able to resolve it by adding index.js in dc.leaflet inside node_module directory with following.

dc = require("dc");
leaflet = require('leaflet');
leaflet.markercluster = require('leaflet.markercluster');
crossfilter = require("crossfilter2");
module.exports = require("./dc.leaflet");

This is something we can not do with application deployment.
Do you have any alternative or better suggestion to so?

@gordonwoodhull
Copy link

Hi @doshisunny, thanks for the report. I'd be glad to add module support to dc.graph.js but I just haven't migrated to ES6 myself so I don't know what goes in the file.

Would you care to open a pull request? I could merge and do a new npm release fairly quickly.

@doshisunny
Copy link
Author

@gordonwoodhull Thank you so much.
I created pull request.

@gordonwoodhull
Copy link

gordonwoodhull commented May 5, 2017

Thanks @doshisunny! Merged in 0.3.2 0.3.3 and published to npm.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants