Skip to content

Commit

Permalink
dcache-xrootd: handle possible race condition in directory listing
Browse files Browse the repository at this point in the history
Motivation:

It seems that cancelTimeout in the directory listing procedure
can be called before the executable object has been assigned,
depending on how quickly the message returns and success is called.

Modification:

Just add a null check, as there is in resetTimeout method.

Result:

The failure reported below should not occur.

Target: master
Request: 4.2
Request: 4.1
Request: 4.0
Request: 3.2
Bug:  RT 9566
Acked-by: Paul
  • Loading branch information
alrossi committed Nov 28, 2018
1 parent 25aefdd commit 19a502a
Showing 1 changed file with 3 additions and 1 deletion.
Expand Up @@ -850,7 +850,9 @@ public synchronized void resetTimeout()
}

public synchronized void cancelTimeout() {
_executionInstance.cancel(false);
if (_executionInstance != null) {
_executionInstance.cancel(false);
}
}
}

Expand Down

0 comments on commit 19a502a

Please sign in to comment.