Skip to content

Commit

Permalink
webdav: http-tpc don't wait if door fails transfer
Browse files Browse the repository at this point in the history
Motivation:

The door may decide to fail the transfer.  This happens if either the
client went away or if RemoteTransferManager claims (repeatedly) that
there is no such transfer.  The latter likely due to the
RemoteTransferService being restarted.

Currently, if this happens then the door will wait
_performanceMarkerPeriod (5 seconds) before informing the client.

There's no reason to delay informing the client (typically FTS).

Modification:

Don't wait to inform the client that a transfer has failed if the door
decides to fail the transfer.

Result:

dCache provides a faster respones to the HTTP-TPC client (typically FTS)
should the door decide to fail a transfer.

Request: 7.2
Request: 7.1
Request: 7.0
Request: 6.2
Requires-notes: yes
Requires-book: no
Patch: https://rb.dcache.org/r/13282/
Acked-by: Albert Rossi
Acked-by: Lea Morschel
  • Loading branch information
paulmillar authored and mksahakyan committed Nov 26, 2021
1 parent 5a49c6a commit 36c108d
Showing 1 changed file with 3 additions and 1 deletion.
Expand Up @@ -1049,7 +1049,9 @@ public synchronized void awaitCompletion() throws InterruptedException {
do {
generateMarker();

wait(_performanceMarkerPeriod);
if (!_finished) {
wait(_performanceMarkerPeriod);
}
} while (!_finished);

if (_problem == null) {
Expand Down

0 comments on commit 36c108d

Please sign in to comment.