Skip to content

Commit

Permalink
nfs: expose dcache version in EXCHANGE_ID operation
Browse files Browse the repository at this point in the history
Motivation:
NFSv4.1 spec allows client and server to exchange their implementation
identities, which can be useful during debugging. Up to now, dCache was
exposing the implementation implementation id of  nfs4j, which is not
quite correct.

Modification:
inject dcache name and version into servers implementation id.

Result:
more info during debugging.

Acked-by: Lea Morschel
Acked-by: Albert Rossi
Target: master
Require-book: no
Require-notes: yes
  • Loading branch information
kofemann committed Aug 2, 2023
1 parent 572f76c commit 633d133
Showing 1 changed file with 3 additions and 0 deletions.
Expand Up @@ -177,6 +177,7 @@
import org.dcache.util.RedirectedTransfer;
import org.dcache.util.Transfer;
import org.dcache.util.TransferRetryPolicy;
import org.dcache.util.Version;
import org.dcache.vehicles.DoorValidateMoverMessage;
import org.dcache.vehicles.FileAttributes;
import org.slf4j.Logger;
Expand Down Expand Up @@ -485,6 +486,8 @@ public void init() throws Exception {
.withExportTable(_exportFile)
.withVfs(_vfs)
.withOperationExecutor(_executor)
.withImplementationName("dcache-" + Version.of(this.getClass()).getBuild())
.withImplementationDate(Instant.parse(Version.of(this.getClass()).getBuildTime()))
.build();

oncRpcSvcBuilder.withRpcService(
Expand Down

0 comments on commit 633d133

Please sign in to comment.