Skip to content

Commit

Permalink
dcache-webdav: fix incorrect parameter value given to DcacheDirectory…
Browse files Browse the repository at this point in the history
…Resource constructor

Motivation:

https://rb.dcache.org/r/14085/

passes the incorrect parameter value in
to the `DcacheDirectoryResource` contstructor.
It should be `true` if this is not a `PROPFIND`
call.

Modification:

Use the `isFetchAllAttributes` method
instead of the variable set from the
property value.

Result:

Correct resource configuration in the
case it is not `PROPFIND`.

Target: master
Patch: https://rb.dcache.org/r/14088/
Request: 9.1
Request: 9.0
Request: 8.2
Requires-notes: no (fixes unreleased change)
Acked-by: Svenja
  • Loading branch information
alrossi committed Sep 6, 2023
1 parent 740940c commit 6362071
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -660,7 +660,7 @@ public DcacheResource getResource(FsPath path) {
private DcacheResource getResource(FsPath path, FileAttributes attributes) {
if (attributes.getFileType() == DIR) {
return new DcacheDirectoryResource(this, path, attributes,
_includeAllAttributesForPropfind);
isFetchAllAttributes());
} else {
return new DcacheFileResource(this, path, attributes);
}
Expand Down Expand Up @@ -1138,7 +1138,7 @@ public void deleteDirectory(PnfsId pnfsid, FsPath path)
pnfs.createPnfsDirectory(path.toString(), REQUIRED_ATTRIBUTES);

return new DcacheDirectoryResource(this, path, reply.getFileAttributes(),
_includeAllAttributesForPropfind);
isFetchAllAttributes());
}

public void move(FsPath sourcePath, PnfsId pnfsId, FsPath newPath)
Expand Down

0 comments on commit 6362071

Please sign in to comment.