Skip to content

Commit

Permalink
resilience: remove check on CUSTODIAL for inaccessible files
Browse files Browse the repository at this point in the history
Motivation:

When a file has no readable replicas, the default behavior of resilience
is to raise an alarm.

Currently, files marked CUSTODIAL are excluded from this.  While from
a certain standpoint, this makes sense, it nevertheless is incorrect
behavior if there is no automatic mechanism to restore the file from
tape (which is missing from the default implementation).

Modification:

Remove the check which excludes CUSTODIAL files.

Result:

An alarm is raised for all files without readable disk copies, whether
the file is CUSTODIAL or not.

(This bug was already fixed on master in patch 10048)

Target: 3.0
Request: 2.16
Acked-by:  DmitryLitvintsev (litvinse@fnal.gov)
  • Loading branch information
alrossi committed Feb 17, 2017
1 parent 2d69d3a commit 657346a
Showing 1 changed file with 1 addition and 3 deletions.
Expand Up @@ -430,9 +430,7 @@ public Type handleVerification(FileAttributes attributes) {
LOGGER.trace("handleVerification, {}, readable locations {}", pnfsId,
readableLocations);

if (readableLocations.size() == 0
&& operation.getRetentionPolicy()
!= FileOperation.CUSTODIAL) {
if (readableLocations.size() == 0) {
Integer pindex = operation.getParent();
if (pindex == null) {
pindex = operation.getSource();
Expand Down

0 comments on commit 657346a

Please sign in to comment.