Skip to content

Commit

Permalink
PnfsManager: remove copy-n-paste error in error message
Browse files Browse the repository at this point in the history
The PnfsManager supports three operations with upload directories:
create, commit and cancel.

Unfortunately, errors from these are logged with the same error message,
likely due to a copy-n-paste mistake.

This patch fixes this by making the error messages unique.

Target: master
Request: 2.14
Request: 2.13
Request: 2.12
Request: 2.11
Request: 2.10
Patch: https://rb.dcache.org/r/8804/
Acked-by: Gerd Behrmann
Requires-notes: true
Requires-book: false
Ticket: http://rt.dcache.org/Ticket/Display.html?id=8844
  • Loading branch information
paulmillar committed Nov 26, 2015
1 parent 7b154e7 commit ef188e5
Showing 1 changed file with 2 additions and 2 deletions.
Expand Up @@ -1209,7 +1209,7 @@ private void commitUpload(PnfsCommitUpload message)
} catch (CacheException e) {
message.setFailed(e.getRc(), e.getMessage());
} catch (RuntimeException e) {
_log.error("Create upload path failed", e);
_log.error("Commit upload path failed", e);
message.setFailed(CacheException.UNEXPECTED_SYSTEM_EXCEPTION, e);
}
}
Expand All @@ -1222,7 +1222,7 @@ private void cancelUpload(PnfsCancelUpload message)
} catch (CacheException e) {
message.setFailed(e.getRc(), e.getMessage());
} catch (RuntimeException e) {
_log.error("Create upload path failed", e);
_log.error("Cancel upload path failed", e);
message.setFailed(CacheException.UNEXPECTED_SYSTEM_EXCEPTION, e);
}
}
Expand Down

0 comments on commit ef188e5

Please sign in to comment.