Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a prototype of scala maven support #44

Merged
merged 2 commits into from Jul 30, 2012
Merged

a prototype of scala maven support #44

merged 2 commits into from Jul 30, 2012

Conversation

mkleint
Copy link
Contributor

@mkleint mkleint commented Jul 26, 2012

based on the current state of groovy maven bridge and code removed from the base maven support.

requires 7.2 because of some additional maven api. module is not friend of maven in 7.2, hopefully my old hack of making yourself friends dynamically still works.

@jglick
Copy link

jglick commented Jul 26, 2012

@@ -1,277 +1,278 @@
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the rewrite - CRLF vs. LF maybe?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely, the IDE's diff showed just the 2 line change..

  1. changed netbeans.version property to RELEASE72
  2. added module scala-maven

@og0815
Copy link
Collaborator

og0815 commented Jul 29, 2012

Not working.
Opening a Maven Project now throws an Exception:

java.lang.ClassNotFoundException: org.netbeans.modules.maven.spi.queries.JavaLikeRootProvider
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:423)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:262)
Caused: java.lang.ClassNotFoundException: org.netbeans.modules.maven.spi.queries.JavaLikeRootProvider starting from ModuleCL@7e768ee6[org.netbeans.modules.org.netbeans.modules.scala.maven] with possible defining loaders [ModuleCL@23e1cfd[org.netbeans.modules.maven]] and declared parents [ModuleCL@685606dc[org.openide.loaders], ModuleCL@23e1cfd[org.netbeans.modules.maven], org.netbeans.MainImpl$BootClassLoader@23390fca, ModuleCL@626d26e[org.openide.nodes], ModuleCL@464f0728[org.netbeans.modules.java.project], ModuleCL@4b7a3607[org.netbeans.modules.projectapi], ModuleCL@5572e44d[org.openide.text], ModuleCL@5efc2b98[org.openide.windows], ModuleCL@158a1cdf[org.netbeans.api.annotations.common], ModuleCL@73a1dd83[org.openide.io], ...1 more]
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:264)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
Caused: java.lang.NoClassDefFoundError: org/netbeans/modules/maven/spi/queries/JavaLikeRootProvider
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:791)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:274)
at org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:300)
Caused: java.lang.NoClassDefFoundError: org/netbeans/modules/maven/spi/queries/JavaLikeRootProvider while loading org.netbeans.modules.scala.maven.ScalaRootProvider; see http://wiki.netbeans.org/DevFaqTroubleshootClassNotFound
at org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:304)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:227)
at org.netbeans.ModuleManager$SystemClassLoader.loadClass(ModuleManager.java:711)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
at org.netbeans.modules.projectapi.LazyLookupProviders.loadPSPInstance(LazyLookupProviders.java:146)
at org.netbeans.modules.projectapi.LazyLookupProviders.access$000(LazyLookupProviders.java:73)
at org.netbeans.modules.projectapi.LazyLookupProviders$1$1.beforeLookup(LazyLookupProviders.java:102)
at org.openide.util.lookup.ProxyLookup.beforeLookup(ProxyLookup.java:210)
at org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:653)
at org.openide.util.lookup.ProxyLookup$R.beforeLookup(ProxyLookup.java:675)
at org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:662)
at org.openide.util.lookup.ProxyLookup$R.computeResult(ProxyLookup.java:550)
at org.openide.util.lookup.ProxyLookup$R.allItems(ProxyLookup.java:534)
at org.openide.util.lookup.ProxyLookup$R.allItems(ProxyLookup.java:529)
at org.openide.util.lookup.ExcludingLookup$R.allItems(ExcludingLookup.java:344)
at org.openide.util.lookup.ExcludingLookup$R.allItems(ExcludingLookup.java:348)
at org.openide.util.lookup.ProxyLookup$LazyCollection.computeSingleResult(ProxyLookup.java:1276)
at org.openide.util.lookup.ProxyLookup$LazyCollection.computeDelegate(ProxyLookup.java:1105)
at org.openide.util.lookup.ProxyLookup$LazyCollection.delegate(ProxyLookup.java:1072)
at org.openide.util.lookup.ProxyLookup$LazyCollection.delegate(ProxyLookup.java:1055)
at org.openide.util.lookup.ProxyLookup$LazyCollection.isEmpty(ProxyLookup.java:1145)
at org.openide.util.lookup.ProxyLookup$R.collectFires(ProxyLookup.java:619)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:170)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:126)
at org.netbeans.spi.project.support.DelegatingLookupImpl.doDelegate(DelegatingLookupImpl.java:178)
at org.netbeans.spi.project.support.DelegatingLookupImpl.resultChanged(DelegatingLookupImpl.java:103)
at org.openide.util.lookup.ProxyLookup$1Notify.run(ProxyLookup.java:181)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:190)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:126)
at org.netbeans.modules.projectapi.LazyLookupProviders$1$1.beforeLookup(LazyLookupProviders.java:113)
at org.openide.util.lookup.ProxyLookup.beforeLookup(ProxyLookup.java:210)
at org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:653)
at org.openide.util.lookup.ProxyLookup$R.beforeLookup(ProxyLookup.java:675)
at org.openide.util.lookup.ProxyLookup$LazyCollection.computeDelegate(ProxyLookup.java:1103)
at org.openide.util.lookup.ProxyLookup$LazyCollection.access$900(ProxyLookup.java:1033)
at org.openide.util.lookup.ProxyLookup$LazyCollection$1.hasNext(ProxyLookup.java:1233)
at org.netbeans.spi.project.ui.support.UILookupMergerSupport$PrivilegedTemplatesImpl.getPrivilegedTemplates(UILookupMergerSupport.java:149)
at org.netbeans.modules.project.ui.OpenProjectList.getTemplateNamesLRU(OpenProjectList.java:1278)
at org.netbeans.modules.project.ui.OpenProjectList.getTemplatesLRU(OpenProjectList.java:1006)
at org.netbeans.modules.project.ui.OpenProjectList.prepareTemplates(OpenProjectList.java:1186)
at org.netbeans.modules.project.ui.OpenProjectList.notifyOpened(OpenProjectList.java:1154)
at org.netbeans.modules.project.ui.OpenProjectList.doOpenProject(OpenProjectList.java:1219)
at org.netbeans.modules.project.ui.OpenProjectList.open(OpenProjectList.java:716)
at org.netbeans.modules.project.ui.OpenProjectList$4.run(OpenProjectList.java:584)
Caused: org.openide.util.RequestProcessor$SlowItem: task failed due to
at org.openide.util.RequestProcessor.post(RequestProcessor.java:424)
at org.netbeans.modules.project.ui.OpenProjectList.open(OpenProjectList.java:580)
at org.netbeans.modules.project.ui.actions.OpenProject$1.run(OpenProject.java:140)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1452)
[catch] at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2032)

@mkleint
Copy link
Contributor Author

mkleint commented Jul 29, 2012

Olivier, just to double check, you used 7.2? I imagine the error would be correct in 7.1

@og0815
Copy link
Collaborator

og0815 commented Jul 29, 2012

Yes, used a clean install of 7.2.

… friends fails.

Additionally add proper nbm display elements
@mkleint
Copy link
Contributor Author

mkleint commented Jul 29, 2012

new commit fixes the problem with codenamebase definition, I seem to be able to install into current dev then.

@og0815
Copy link
Collaborator

og0815 commented Jul 30, 2012

Will look into it this evening.

@og0815
Copy link
Collaborator

og0815 commented Jul 30, 2012

Welll ... No.

java.lang.ClassNotFoundException: org.netbeans.modules.maven.spi.queries.JavaLikeRootProvider
at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
at java.lang.ClassLoader.loadClass(ClassLoader.java:423)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:262)
Caused: java.lang.ClassNotFoundException: org.netbeans.modules.maven.spi.queries.JavaLikeRootProvider starting from ModuleCL@32f06b32[org.netbeans.modules.scala.maven] with possible defining loaders [ModuleCL@4833240b[org.netbeans.modules.maven]] and declared parents [ModuleCL@355a847[org.netbeans.modules.java.project], ModuleCL@6ea3fff1[org.netbeans.api.annotations.common], ModuleCL@126ec30c[org.openide.io], org.netbeans.MainImpl$BootClassLoader@23390fca, ModuleCL@3e68941f[org.openide.nodes], ModuleCL@4833240b[org.netbeans.modules.maven], ModuleCL@214dd657[org.netbeans.modules.projectuiapi], ModuleCL@3a3a5631[org.openide.text], ModuleCL@3c21fd47[org.openide.windows], ModuleCL@40f6a33b[org.netbeans.modules.projectapi], ...1 more]
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:264)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
Caused: java.lang.NoClassDefFoundError: org/netbeans/modules/maven/spi/queries/JavaLikeRootProvider
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:791)
at org.netbeans.JarClassLoader.doLoadClass(JarClassLoader.java:274)
at org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:300)
Caused: java.lang.NoClassDefFoundError: org/netbeans/modules/maven/spi/queries/JavaLikeRootProvider while loading org.netbeans.modules.scala.maven.ScalaRootProvider; see http://wiki.netbeans.org/DevFaqTroubleshootClassNotFound
at org.netbeans.ProxyClassLoader.selfLoadClass(ProxyClassLoader.java:304)
at org.netbeans.ProxyClassLoader.loadClass(ProxyClassLoader.java:227)
at org.netbeans.ModuleManager$SystemClassLoader.loadClass(ModuleManager.java:711)
at java.lang.ClassLoader.loadClass(ClassLoader.java:356)
at org.netbeans.modules.projectapi.LazyLookupProviders.loadPSPInstance(LazyLookupProviders.java:146)
at org.netbeans.modules.projectapi.LazyLookupProviders.access$000(LazyLookupProviders.java:73)
at org.netbeans.modules.projectapi.LazyLookupProviders$1$1.beforeLookup(LazyLookupProviders.java:102)
at org.openide.util.lookup.ProxyLookup.beforeLookup(ProxyLookup.java:210)
at org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:653)
at org.openide.util.lookup.ProxyLookup$R.beforeLookup(ProxyLookup.java:675)
at org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:662)
at org.openide.util.lookup.ProxyLookup$R.computeResult(ProxyLookup.java:550)
at org.openide.util.lookup.ProxyLookup$R.allItems(ProxyLookup.java:534)
at org.openide.util.lookup.ProxyLookup$R.allItems(ProxyLookup.java:529)
at org.openide.util.lookup.ExcludingLookup$R.allItems(ExcludingLookup.java:344)
at org.openide.util.lookup.ExcludingLookup$R.allItems(ExcludingLookup.java:348)
at org.openide.util.lookup.ProxyLookup$LazyCollection.computeSingleResult(ProxyLookup.java:1276)
at org.openide.util.lookup.ProxyLookup$LazyCollection.computeDelegate(ProxyLookup.java:1105)
at org.openide.util.lookup.ProxyLookup$LazyCollection.delegate(ProxyLookup.java:1072)
at org.openide.util.lookup.ProxyLookup$LazyCollection.delegate(ProxyLookup.java:1055)
at org.openide.util.lookup.ProxyLookup$LazyCollection.isEmpty(ProxyLookup.java:1145)
at org.openide.util.lookup.ProxyLookup$R.collectFires(ProxyLookup.java:619)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:170)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:126)
at org.netbeans.spi.project.support.DelegatingLookupImpl.doDelegate(DelegatingLookupImpl.java:178)
at org.netbeans.spi.project.support.DelegatingLookupImpl.resultChanged(DelegatingLookupImpl.java:103)
at org.openide.util.lookup.ProxyLookup$1Notify.run(ProxyLookup.java:181)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:190)
at org.openide.util.lookup.ProxyLookup.setLookups(ProxyLookup.java:126)
at org.netbeans.modules.projectapi.LazyLookupProviders$1$1.beforeLookup(LazyLookupProviders.java:113)
at org.openide.util.lookup.ProxyLookup.beforeLookup(ProxyLookup.java:210)
at org.openide.util.lookup.ProxyLookup$R.myBeforeLookup(ProxyLookup.java:653)
at org.openide.util.lookup.ProxyLookup$R.beforeLookup(ProxyLookup.java:675)
at org.openide.util.lookup.ProxyLookup$LazyCollection.computeDelegate(ProxyLookup.java:1103)
at org.openide.util.lookup.ProxyLookup$LazyCollection.access$900(ProxyLookup.java:1033)
at org.openide.util.lookup.ProxyLookup$LazyCollection$1.hasNext(ProxyLookup.java:1233)
at org.netbeans.spi.project.ui.support.UILookupMergerSupport$PrivilegedTemplatesImpl.getPrivilegedTemplates(UILookupMergerSupport.java:149)
at org.netbeans.modules.project.ui.OpenProjectList.getTemplateNamesLRU(OpenProjectList.java:1278)
at org.netbeans.modules.project.ui.OpenProjectList.getTemplatesLRU(OpenProjectList.java:1006)
at org.netbeans.modules.project.ui.OpenProjectList.prepareTemplates(OpenProjectList.java:1186)
at org.netbeans.modules.project.ui.OpenProjectList.notifyOpened(OpenProjectList.java:1154)
at org.netbeans.modules.project.ui.OpenProjectList.doOpenProject(OpenProjectList.java:1219)
at org.netbeans.modules.project.ui.OpenProjectList.open(OpenProjectList.java:716)
at org.netbeans.modules.project.ui.OpenProjectList$4.run(OpenProjectList.java:584)
Caused: org.openide.util.RequestProcessor$SlowItem: task failed due to
at org.openide.util.RequestProcessor.post(RequestProcessor.java:424)
at org.netbeans.modules.project.ui.OpenProjectList.open(OpenProjectList.java:580)
at org.netbeans.modules.project.ui.actions.OpenProject$1.run(OpenProject.java:140)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1452)
[catch] at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2032)

@og0815
Copy link
Collaborator

og0815 commented Jul 30, 2012

Or did you mean, we won't get it running till 7.2.1 ?

@og0815
Copy link
Collaborator

og0815 commented Jul 30, 2012

Found a solution. (Using Implementation Depenedencies overwrites Friends)
I will merge the pull and add the changes afterwards.

og0815 added a commit that referenced this pull request Jul 30, 2012
a prototype of scala maven support
@og0815 og0815 merged commit 94b0df4 into dcaoyuan:master Jul 30, 2012
@mkleint
Copy link
Contributor Author

mkleint commented Jul 31, 2012

the friend clause in o.n.m.maven will be live in 7.3 only.
implementation dependency means that 7.2 and 7.3 (and dev) will need separate binary of scala.maven module. if the maven base module changes in 7.2.1 or other patch releases, the impl dependency will fail as well.

I've tried in 7.3 dev, my execution might have been influenced by the fact that the friend clause was already there.

@og0815
Copy link
Collaborator

og0815 commented Jul 31, 2012

I'm aware of this, but I don't think it's such a big deal.
I will update the ReadMe.md and suply the download packages.
To recompile and create an extra download if 7.2.1 arrives will happen fast.

@mkleint
Copy link
Contributor Author

mkleint commented Jul 31, 2012

yup. my fault. I've used binaries with friend already set..
mkleint@91fb809 fixes the issue with reflection, internals of netbeans have changed since 6.x when I used it last time. works in 7.2.

If you decide not to use it, then removing the ModInstall class and the associated manifest entry makes sense.

og0815 added a commit that referenced this pull request Nov 13, 2012
a prototype of scala maven support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants