New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a prototype of scala maven support #44
Conversation
Please help get http://wiki.netbeans.org/NbmPackageStability#Usage_from_external_modules fixed... :-) |
@@ -1,277 +1,278 @@ | |||
<?xml version="1.0" encoding="UTF-8"?> | |||
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the rewrite - CRLF vs. LF maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most likely, the IDE's diff showed just the 2 line change..
- changed netbeans.version property to RELEASE72
- added module scala-maven
Not working. java.lang.ClassNotFoundException: org.netbeans.modules.maven.spi.queries.JavaLikeRootProvider |
Olivier, just to double check, you used 7.2? I imagine the error would be correct in 7.1 |
Yes, used a clean install of 7.2. |
… friends fails. Additionally add proper nbm display elements
new commit fixes the problem with codenamebase definition, I seem to be able to install into current dev then. |
Will look into it this evening. |
Welll ... No. java.lang.ClassNotFoundException: org.netbeans.modules.maven.spi.queries.JavaLikeRootProvider |
Or did you mean, we won't get it running till 7.2.1 ? |
Found a solution. (Using Implementation Depenedencies overwrites Friends) |
a prototype of scala maven support
the friend clause in o.n.m.maven will be live in 7.3 only. I've tried in 7.3 dev, my execution might have been influenced by the fact that the friend clause was already there. |
I'm aware of this, but I don't think it's such a big deal. |
yup. my fault. I've used binaries with friend already set.. If you decide not to use it, then removing the ModInstall class and the associated manifest entry makes sense. |
a prototype of scala maven support
based on the current state of groovy maven bridge and code removed from the base maven support.
requires 7.2 because of some additional maven api. module is not friend of maven in 7.2, hopefully my old hack of making yourself friends dynamically still works.