Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing player in players file #156

Open
wsciekly-kredens opened this issue Feb 25, 2023 · 1 comment
Open

Missing player in players file #156

wsciekly-kredens opened this issue Feb 25, 2023 · 1 comment
Labels
dataset enhancement New feature or request

Comments

@wsciekly-kredens
Copy link

Hello, while working with set I noticed, that Norwich City, Marquinhos (id = 668268) is missing in players table. I think there might be an issue with players of the same name. Or at least with this specyfic player.

@dcaribou dcaribou added enhancement New feature or request dataset labels Feb 26, 2023
@dcaribou
Copy link
Owner

dcaribou commented Feb 26, 2023

Hey @wsciekly-kredens. Thanks for raising the issue.

The reason why Marquinhos is not in the players asset is that Norwich City is now a club from the second league. It was part of premier league last season, that's why the team and the players of that season are captured in the datasets but new players from this season are not.

While I'd love to scrape clubs down to the second tier it's not practical for me to do so at the moment, so I have to cap the scraping to first tier only. I think this probably can be more clearly stated in the docs. I'll make sure to add a disclaimer about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataset enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants