Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the compatibility issues with nova v4.32+ #96

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

hello-liang-shan
Copy link
Member

No description provided.

@hello-liang-shan hello-liang-shan marked this pull request as ready for review February 1, 2024 13:05
@hello-liang-shan
Copy link
Member Author

hello-liang-shan commented Feb 1, 2024

close #93 #94

This was linked to issues Feb 2, 2024
@milewski
Copy link
Member

milewski commented Feb 2, 2024

Having 2 mega filters stopped to work...

@hello-liang-shan hello-liang-shan marked this pull request as draft February 2, 2024 04:42
@milewski
Copy link
Member

milewski commented Feb 2, 2024

Now some filters are gone... for example SliderFilter is not being rendered anymore...

@milewski
Copy link
Member

milewski commented Feb 2, 2024

Wait @hello-liang-shan actually it was not multiple mega filter it was 1 nova dashboard filters + mega filter .. because they looks exactly the same I forgot about it, But I think it is fine only allowing 1 mega filter to be used.. It would mess too much with the store supporting multiple

@hello-liang-shan hello-liang-shan marked this pull request as ready for review February 2, 2024 05:20
@hello-liang-shan
Copy link
Member Author

Wait @hello-liang-shan actually it was not multiple mega filter it was 1 nova dashboard filters + mega filter .. because they looks exactly the same I forgot about it, But I think it is fine only allowing 1 mega filter to be used.. It would mess too much with the store supporting multiple

now multiple mega filters is supported. I think it's useful to support multiple, especially when there are a lot of filters.

@milewski
Copy link
Member

milewski commented Feb 2, 2024

It still not showing all my filters,... I have 3 but only 1 is being shown:

image

@hello-liang-shan
Copy link
Member Author

image
image
this is mine, it works correctly. I'm testing it in a new project..

@milewski
Copy link
Member

milewski commented Feb 2, 2024

Try to use the slider filter.. it is not showing on this version...

@hello-liang-shan
Copy link
Member Author

Try to use the slider filter.. it is not showing on this version...

image
also works, maybe some other packages are broken?

@milewski
Copy link
Member

milewski commented Feb 5, 2024

This is what I have:

MegaFilter::make([

    FavoriteColor::make('Color 3')->wrapMode()->noneLabel('Any'),
    UserType::make(),
    LikesFilter::make('Slider 1')->single(10, 500),

]),

It Renders like this:

image

if I duplicate it:

MegaFilter::make([

    FavoriteColor::make('Color 3')->wrapMode()->noneLabel('Any'),
    UserType::make(),
    LikesFilter::make('Slider 1')->single(10, 500),

]),

MegaFilter::make([

    FavoriteColor::make('Color 3')->wrapMode()->noneLabel('Any'),
    UserType::make(),
    LikesFilter::make('Slider 1')->single(10, 500),

]),

It renders like this:

image

And If I change the filter on the MegaFilter 1 .. it also affects the mega filter 2...

image

image

But if I rollback to the previous version:

image

@hello-liang-shan
Copy link
Member Author

I think nova also has the issue if you add 2 same filter.
image

image

@hello-liang-shan
Copy link
Member Author

hello-liang-shan commented Feb 5, 2024

image

I dont know why you have this issue, but I tested all nova/pill/slider... filters, they all work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Index view reloading & Sparkline field Translation & Url
2 participants