Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing WEAT words #52

Open
kato8966 opened this issue Nov 15, 2023 · 3 comments
Open

Missing WEAT words #52

kato8966 opened this issue Nov 15, 2023 · 3 comments

Comments

@kato8966
Copy link

There are two versions of unpleasant_5 words in the original WEAT paper. One of them is used in WEAT 1, and the other is used in WEAT 3. (For example, the former includes "prison," while the latter does not.) However, wefe/datasets/data/WEAT.json has only the former.

I fixed the problem by renaming unpleasant_5 to unpleasant_5a and adding unpleasant_5b (This is the fix branch. https://github.com/kato8966/wefe/tree/fix-weat-words), but this breaks backward compatibility.

Should I proceed and make a PR, or should I try a different approach?

@pbadillatorrealba
Copy link
Member

Hi @kato8966 ,

Thanks for noticing it and trying to correct it!
Yes, make a pull request to develop and we will evaluate it.
Most likely we will have to change the experiments notebook.

@kato8966
Copy link
Author

Sorry, but I'm currently busy and don't have enough time to fix all the problems caused by this compatibility-breaking change. What do you think I should do?

@pbadillatorrealba
Copy link
Member

No problem :)
Just upload the patch with the words and I will correct the compatibility issues later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants