Add database session and fix store session

[watzon]

This PR adds a DatabaseSession which uses denodb to allow session creation with Postgres, MySQL, MariaDB, SQLite, and MongoDB. For now this makes us dependent on denodb, which I don't love, but that could be mitigated by separating this out into its own package or relying on some kind of dependency injection.

I also managed to fix StoreSession. It was actually just a single missed line that was keeping it from working.

[dcdunkan]

This is amazing! Nice work. I'll do a review within a few hours. Thank you so much.

I also managed to fix StoreSession. It was actually just a single missed line that was keeping it from working.

Haha. Thanks for that too! If I remember correctly. I rewrote those session files, rather than copying it. And I never tested or re-checked it. Thank you for the fix <3

[dcdunkan]

LGTM. I'll merge as soon as the discussions are resolved.

I was thinking about adding more examples on using grm. I'd appreciate if you can add a minimal example on using this database session.

[watzon]

There is one issue that I'm having, and I need someone else to test and see if this is just me or a bigger underlying problem. Some channels seem to be failing to get added to the entities, but also not. For instance my bot's log channel (which is private).

This problem only happens on restart. If you send a message in the channel while the bot is running, and then look for that channel with the bot you'll find it, but once the bot restarts it's gone again.

[watzon]

Never mind, I fixed the persistence issues. Still not 100% sure why it's fixed, but everything works as expected now.

[dcdunkan]

To be consistent with the file names, rename the databaseSession.ts file to database_session.ts.

And also, there is a conflict as you may have noticed. So it's the examples/basic.ts file now. Not simple.ts.

[watzon]

I believe we're good now

[dcdunkan]

I think no. We have issues with examples as I see. Seems like you now only have databaseSession.ts. We need both basic and databaseSession examples. What I meant about renaming was to rename databaseSession.ts to database_session.ts. And not touch basic.ts.

[dcdunkan]

If that's done, I think we're good and I'll merge this

[dcdunkan]

Its okay if you can't figure out the issue with the examples. Just revert adding the examples. I'll add them myself later.

[watzon]

Wait, did it get removed? My branch has it locally and shows that the changes were pushed. I thought it wasn't showing up just because that file now matches the main branch, so it's not showing changes.

[dcdunkan]

@watzon It looks like it is removed/modified as database_session.ts. Can you fix that, and resolve these conflicts? We had some breaking changes in #6

[watzon]

Man rebasing is not my strong suit, but I think I got everything in place

[dcdunkan]

Is everything working alright? I haven't tested this stuff yet. If everything's fine, I'll merge this.

[watzon]

It's working for my userbot, but without tests I can't really guarantee anything

…

________________________________ From: Dunkan ***@***.***> Sent: Sunday, July 17, 2022 9:41:23 AM To: dcdunkan/grm ***@***.***> Cc: Chris Watson ***@***.***>; Mention ***@***.***> Subject: Re: [dcdunkan/grm] Add database session and fix store session (PR #4) Is everything working alright? I haven't tested this stuff yet. If everything's fine, I'll merge this. — Reply to this email directly, view it on GitHub<#4 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABCTI7U34EPMMXBC3BJ65ULVUQSSHANCNFSM53W4YLNQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[dcdunkan]

I think I'll merge it. We're on 0.x anyway. Thanks for the PR!