Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDUDecoder.decodeDIMSE logs dataset twice with debug log level #751

Closed
dhohmeier opened this issue Jul 16, 2020 · 0 comments
Closed

PDUDecoder.decodeDIMSE logs dataset twice with debug log level #751

dhohmeier opened this issue Jul 16, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@dhohmeier
Copy link

Describe the bug
PDUDecoder.decodeDIMSE logs dataset twice with debug log level.

To Reproduce
Steps to reproduce the behavior:

  1. Enable DEBUG log level.
  2. Execute a C-FIND with a non-empty query response.
  3. Inspect log output for redundant "Dataset:" logging.

Expected behavior
Dataset should be logged only once from PDUDecoder.

Screenshots
n.a.

Desktop (please complete the following information):

  • OS: [Win10]
  • Browser [chrome]
  • Version [dcm4che 5.22.3]

Additional context
Removal of line 458 from PDUDecoder can solve the issue.
458 Dimse.LOG.debug("Dataset:\n{}", data);
459 if (Dimse.LOG.isDebugEnabled()) {
460 Dimse.LOG.debug("{} >> {} Dataset:\n{}", as, dimse.toString(cmd), data);
461 }

@gunterze gunterze self-assigned this Sep 9, 2020
@gunterze gunterze added the bug label Sep 9, 2020
@gunterze gunterze added this to the 5.22.5 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants