Wrong storage-sop-classes.properties UID Renaming

[NicolasLaheurte]

In dcm4che-assembly/src/etc/dcmqrscp/storage-sop-classes.properties it seems the keyword "Retired" has been removed also when unnecessary.

Seen issues:

1. UltrasoundMultiFrameImageStorageRetired
   UltrasoundMultiFrameImageStorage
   Both renamed to:
   UltrasoundMultiFrameImageStorage

2. UltrasoundImageStorageRetired
   UltrasoundImageStorage
   Both renamed to:
   UltrasoundImageStorage

3. "NuclearMedicineImageStorageRetired" became "NuclearMedicineImageStorage" which isn't the same UID (both are existing).

No issue seen in query-sop-classes.properties / retrieve-sop-classes.properties but the same issue is found in sop-classes.properties.

[jssuttles]

Hey,
This fix wasn't quite right.
NuclearMedicineImageStorage is different from NuclearMedicineImageStorageRetired.
1.2.840.10008.5.1.4.1.1.20
vs
1.2.840.10008.5.1.4.1.1.5

[gunterze]

Hey, This fix wasn't quite right. NuclearMedicineImageStorage is different from NuclearMedicineImageStorageRetired. 1.2.840.10008.5.1.4.1.1.20 vs 1.2.840.10008.5.1.4.1.1.5

Fixed files contain

NuclearMedicineImageStorage:*

and

NuclearMedicineImageStorageRetired:*

!

[jssuttles]

Hunh. Sorry about that. You're right. Somehow I missed that in my search. Thanks!

[jssuttles]

Hi, sorry for bothering you again.
But I just checked through https://github.com/dcm4che/dcm4che/blob/master/dcm4che-assembly/src/etc/storescp/sop-classes.properties again and it's not there.
It was removed in ba4626d#diff-777459a77c74a7f0837eb94f2a5a7141f4d8a8269affcb4dc2ef263e225b5eca.
Does this commit make sense?

[gunterze]

Also don't see the intention of ba4626d
Will ask @nroduit .

[nroduit]

The intention was only to remove duplicates. However, I don't see any duplicates now!

[gunterze]

Duplicates were already removed by 738437d , so when ba4626d removed NuclearMedicineImageStorage:*, only NuclearMedicineImageStorageRetired:* remained.