Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to add new JsonDicomConfigurationExtension by CDI Producers #2888

Closed
gunterze opened this issue Nov 30, 2020 · 0 comments
Closed

Enable to add new JsonDicomConfigurationExtension by CDI Producers #2888

gunterze opened this issue Nov 30, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@gunterze
Copy link
Member

gunterze commented Nov 30, 2020

Replace hard-coded list of registered JsonDicomConfigurationExtensions

    @Produces
    @ApplicationScoped
    public static JsonConfiguration newJsonConfiguration() {
        JsonConfiguration config = new JsonConfiguration();
        config.addJsonConfigurationExtension(new JsonAuditLoggerConfiguration());
        config.addJsonConfigurationExtension(new JsonAuditRecordRepositoryConfiguration());
        config.addJsonConfigurationExtension(new JsonImageReaderConfiguration());
        config.addJsonConfigurationExtension(new JsonImageWriterConfiguration());
        JsonHL7Configuration hl7Config = new JsonHL7Configuration();
        hl7Config.addHL7ConfigurationExtension(new JsonArchivHL7Configuration());
        config.addJsonConfigurationExtension(hl7Config);
        config.addJsonConfigurationExtension(new JsonArchiveConfiguration());
        config.addJsonConfigurationExtension(new JsonArchiveUIConfiguration());
        return config;
    }

by

    @Produces
    @ApplicationScoped
    public static JsonConfiguration newJsonConfiguration(Instance<JsonConfigurationExtension> configExts) {

So a JsonDicomConfigurationExtension can be added by declaring its implementation class as @ApplicationScoped bean, e.g.:

@ApplicationScoped
public class JsonArchiveUIConfiguration extends JsonConfigurationExtension {

or providing it by a Producer method or field, e.g.

    @Produces
    @ApplicationScoped
    private static JsonAuditLoggerConfiguration jsonAuditLoggerConfiguration =
            new JsonAuditLoggerConfiguration();

Related #2797

@gunterze gunterze added the enhancement New feature or request label Nov 30, 2020
@gunterze gunterze added this to the 5.23.0 milestone Nov 30, 2020
@gunterze gunterze self-assigned this Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant