Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a few minor tweaks #18

Open
bbnsn opened this issue Jul 17, 2021 · 0 comments
Open

a few minor tweaks #18

bbnsn opened this issue Jul 17, 2021 · 0 comments

Comments

@bbnsn
Copy link

bbnsn commented Jul 17, 2021

first up - thanks for doing this driver!
i had some issues getting my fans to work reliably - in particular i regularly had fan state issues.
i took a look at your code and figured it out.
(1) POLLING SCHEDULE: it had not occurred to me that the max. I could enter in the Polling Interval field would be 59 seconds , being a limitation based on the format of the schedule method. i'm super wary of constant polling - particularly as this is using sync HTTP calls - so i entered 120 seconds for the polling interval, and of course the schedule errored out but the UI gave no indication. so to allow for longer intervals, and also for non-coders (and coders who should know better - thats me BTW) i thought i'd add a minutes field and also tweak the input field descriptions.
(2) the BOND to HE command translations did not cater for 1 speed, which some of my fans had, so none of the commands would work. i added a 'one speed' option to the maps in the 2 methods.

a couple minor tweaks and 'issues' they are no more, they're pretty darn minor and tested OK....i have simply collated the changed methods in a .txt file, which you can compare to your original (I am on HPM, so was using the latest version with the latest revision in comments being:

"2020.06.28 - Added toggle command to all devices (suggested by jchurch) and support for having multiple Smart by BOND devices (discovered by jhciotti)"

if you could add these suggestions that would be great, provided you have no issues including them.
Suggested Mods to BOND home.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant