Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOW-RS is not encoding the "Content-Type" according to standard #113

Open
Zaid-Safadi opened this issue Mar 16, 2020 · 5 comments
Open
Labels

Comments

@Zaid-Safadi
Copy link

In OHIF viewer the store measurements is failing when storing to DICOMlcoud server. see this issue for reference.

I traced this and it is caused by the server not recognizing the "Content-Type" header ( Built-in .NET library) because it is not not formatted properly.

For STOW-RS, the Content-Type is being sent as:
Content-Type: multipart/related; type=application/dicom; boundary=2afeebaf-038d-792a-f952-d8e249ba8e96

The correct format should be:
Content-Type: multipart/related; type="application/dicom"; boundary="2afeebaf-038d-792a-f952-d8e249ba8e96"

Notice the "Quotation mark" around the type and boundary parameters: type="application/dicom"

This used to be a bug in the DICOM standard when DICOMweb was initially released but then they corrected it to match the HTTP RFC specs:
I think this is the new reference: http://dicom.nema.org/medical/dicom/current/output/html/part18.html#sect_8.7.3.5.1
and
https://tools.ietf.org/html/rfc2387

@JamesAPetts
Copy link
Collaborator

I think this issue is likely inside dicomweb-client, not dcmjs?

@JamesAPetts
Copy link
Collaborator

Oh no, it likely is in dcmjs, my mistake.

@pieper
Copy link
Collaborator

pieper commented Jul 1, 2020

Is there an easy way to replicate this issue?

@Zaid-Safadi
Copy link
Author

Hey @pieper , you can use the public endpoint of DICOMcloud to replicate this with OHIF when saving Measurements via SR.
http://dicomcloud.azurewebsites.net/api/studies

@Dev-Now
Copy link

Dev-Now commented Sep 21, 2020

@Zaid-Safadi @JamesAPetts This is actually in dicomweb-client/src/api.js.
I need this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants