Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Publish and build package on newer node #391

Merged
merged 1 commit into from
May 6, 2024

Conversation

wayfarer3130
Copy link
Contributor

@wayfarer3130 wayfarer3130 commented May 6, 2024

Updated a number of versions, and started fixing the circular dependency issues to try to get the overall build/release working.
This does change the node version used to build, as well as the rollup version being used, but is intended to be entirely non-functional, just changing things trying to get the main build working.
@pieper - this PR is just more than a basic test to try to release things again, so I'd like you to take a look before I push it.

Copy link

netlify bot commented May 6, 2024

Deploy Preview for dcmjs2 ready!

Name Link
🔨 Latest commit bbd1d6c
🔍 Latest deploy log https://app.netlify.com/sites/dcmjs2/deploys/6639083ae2a8e30008f059f2
😎 Deploy Preview https://deploy-preview-391--dcmjs2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wayfarer3130 wayfarer3130 requested a review from pieper May 6, 2024 19:10
Copy link
Collaborator

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍

I think those changes all look reasonable.

@pieper pieper merged commit 60b1c99 into master May 6, 2024
14 checks passed
@pieper pieper deleted the fix/deploy-invalid-dicom-fix branch May 6, 2024 19:22
Copy link

github-actions bot commented May 6, 2024

🎉 This PR is included in version 0.31.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pieper
Copy link
Collaborator

pieper commented May 6, 2024

Now that the deploys are working it's time to actually fix the examples. There are CORS issues and some other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants