Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in referenced instances #4

Open
fedorov opened this issue Jul 6, 2017 · 4 comments
Open

Inconsistencies in referenced instances #4

fedorov opened this issue Jul 6, 2017 · 4 comments
Labels

Comments

@fedorov
Copy link
Collaborator

fedorov commented Jul 6, 2017

There is an inconsistency between the instances referenced here

image

and in the per-frame derivation image sequence

image

@fedorov fedorov added the bug label Jul 6, 2017
@pieper
Copy link
Collaborator

pieper commented Jul 6, 2017

Can you describe which example you used? (is this from SR or SEG example).

@fedorov
Copy link
Collaborator Author

fedorov commented Jul 6, 2017

SEG. I didn't check if SR has the same problem (it will need to handle references in a similar way).

@pieper
Copy link
Collaborator

pieper commented Jul 6, 2017

The reason for this is that the original MRImages are converted to a multiframe before the SEG or SR are created so the reference series are the original single frames but the derivation series is the multiframe. I'll have another look at the logic and decide which one makes the most sense to include in each place.

@pieper
Copy link
Collaborator

pieper commented Jul 6, 2017

For reference here is the code in question:

https://github.com/pieper/dcmjs/blob/master/src/derivations.js#L239-L257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants