Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Signed-off-by in pull request text #74

Closed
DL6ER opened this issue May 17, 2018 · 9 comments
Closed

Read Signed-off-by in pull request text #74

DL6ER opened this issue May 17, 2018 · 9 comments
Labels

Comments

@DL6ER
Copy link

DL6ER commented May 17, 2018

Dear DCO developers,

we use your bot to enforce Sign-Off lines by our users in our project. However, we often receive external contributions from users with few (or no) previous experience with Github and adding a Signed-Off-by message in all of their commits (by walking the tree and rewriting things) is something that is a bit complex to explain to newcomers.

Hence, our own solution was to ask users to just edit in the requested line into the pull request message and we accept this as being equivalent. However, DCO does not read the pull request text for these lines and hence we have to ignore its false positive for merging.

Can interpreting the pull request text be added in order to ease the process for git newcomers?

@hiimbex
Copy link
Contributor

hiimbex commented May 18, 2018

I'm not opposed to this at all; however, I think some orgs that are stricter in their requiring of DCO might not love this idea, so what about adding this feature as an additional field in the .github/dco.yml as allowPRSignOff: true (and have it be false by default)?

@DL6ER
Copy link
Author

DL6ER commented May 18, 2018

Yes, that would be a great idea.

@stale
Copy link

stale bot commented Aug 16, 2018

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Aug 16, 2018
@bkeepers
Copy link
Contributor

I think this would help a lot with usability.

@stale stale bot removed the wontfix label Aug 17, 2018
@stale
Copy link

stale bot commented Nov 16, 2018

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Nov 16, 2018
@DL6ER
Copy link
Author

DL6ER commented Nov 16, 2018

Yes, this is still relevant.

@stale stale bot removed the wontfix label Nov 16, 2018
@Warchant
Copy link
Contributor

Is anyone working on this?

@itayd
Copy link

itayd commented Feb 2, 2019

Hi, I suggest an alternative solution in #105. Feel free to share your thoughts.

@stale
Copy link

stale bot commented May 3, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 3, 2019
@stale stale bot closed this as completed Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants