New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should Enum value be primitive instead of Number? #510

Closed

dreamershl opened this issue Dec 1, 2016 · 1 comment

Labels

dreamershl commented Dec 1, 2016

the new version use the Number() to parse the Enum type. But the message field value is primitive. Then the '===' can't be used for comparison.

dcodeIO closed this as completed in

6e5fdb6

dcodeIO added the enhancement label

Member

dcodeIO commented Dec 1, 2016

It's now a plain number without a wrapper but enum value options aren't exposed anymore. Shouldn't be a problem, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment