Issues/775

[pavelstudeny]

fixes #775

• all unknown fields are deserialized into a single array __unknownFields
• __unknownFields are serialized at the end
• discardUnknownFields() remove the unknown fields from the deserialized data
• a global option to ignore unknown fields is not present. if required, please suggest where to place it

[pavelstudeny]

seems that writeBytes (the one using util.Array) might be incorrect on older node versions, but it was probably never called until now

[jcgertig]

is this able to just handle encoding unkown Ids that are passed in like say

{
 SomeKnownKey: 1,
 9999: 'Some unknown id'
}

[jcgertig]

Or do I have to put that id in the __unknownFields myself?

[pavelstudeny]

@jcgertig it creates the __unknownFields automatically. Seeing this issue neither accepted nor rejected for more than a year, however, I'm wondering what's planned with this project now that Google provides built-in JavaScript support

[chakmingli]

If you fork and apply this change, it will be really helpful for many people.

[jeremyong]

I looked at the tests and literally everything passed but there was an issue with CODECLIMATE_REPO_TOKEN.

This would be a really helpful merge, as this library isn't compliant with the protobuf specification without it.

[jeremyong]

@pavelstudeny Is there a reason you opted to make the unknown fields hidden?

[pavelstudeny]

@jeremyong do you mean that the __unknownFields have enumerable set to false by "hidden"? Yes, since they are unknown, there is not much you can do with them in an enumeration.