Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pods: Network name is missing on the review screen #3336

Closed
nLight opened this issue Oct 5, 2018 · 20 comments
Closed

Pods: Network name is missing on the review screen #3336

nLight opened this issue Oct 5, 2018 · 20 comments

Comments

@nLight
Copy link
Contributor

nLight commented Oct 5, 2018

Please refer to the ticket https://jira.mesosphere.com/browse/DCOS_OSS-1370

Needs to be added to: https://github.com/dcos/dcos-ui/blob/master/plugins/services/src/js/service-configuration/PodNetworkConfigSection.js

@adityatandon007
Copy link

@nLight can I pick this too!

@nLight
Copy link
Contributor Author

nLight commented Oct 5, 2018

@adityatandon007 it's yours :) Thanks!

@adityatandon007
Copy link

@nLight Does this require the cluster

@nLight
Copy link
Contributor Author

nLight commented Oct 5, 2018

@adityatandon007 I'd say no. You can hit the same screen by trying to launch a multicontainer service:
oct-05-2018 17-07-52

@adityatandon007
Copy link

@nLight I am unable to launch a multi container service

@nLight
Copy link
Contributor Author

nLight commented Oct 5, 2018

@adityatandon007 what is the issue? You don't need to launch it just Proceed until the Review screen

@adityatandon007
Copy link

@nLight I couldn't launch a multi container service. Here is a screen shot and I figured that I have to add some like this.
<ConfigurationMapRow> <ConfigurationMapLabel>Network Name</ConfigurationMapLabel> <ConfigurationMapValueWithDefault value={getNetworkTypes(appConfig.networks)} /> {action} </ConfigurationMapRow> but I couldn't start a new multicontainer service. How can I start that.
screenshot from 2018-10-05 22-13-45

@adityatandon007
Copy link

@nLight Here is how my services section look. I think there is something wrong with the setup I am not able to see the + icon to add a new service.
screenshot from 2018-10-05 22-20-32

@adityatandon007
Copy link

@nLight any help would be great

@nLight
Copy link
Contributor Author

nLight commented Oct 8, 2018

@adityatandon007 hey, I think those are quirks of running the UI of fixtures. You can't really start anything without a cluster. But clicking into /some/group-with-pods/podEFGH should let you see the screen. As I can see from the fixture there is a network with a name.

@nLight
Copy link
Contributor Author

nLight commented Oct 9, 2018

Hey @adityatandon007 is there anything I could do to unblock you?

@adityatandon007
Copy link

adityatandon007 commented Oct 9, 2018

@nLight didn't get what you mean by

is there anything I could do to unblock you?

By the way I didn't get the time to look into this. I will try to get to that review screen without starting the cluster. Because I don't know how to set up a cluster.

@adityatandon007
Copy link

@nLight nope couldn't get to the review screen for a multicontainer pod.

@adityatandon007
Copy link

@nLight I think I would need to give the cluster url in my config file. But for that I would have to setup an aws cluster. I don't want to go throught that setup. Is there any dummy cluster url that I can add to config file to start the cluster. If there is no other way to set up a cluster url then, some else is free to pick this up!

@nLight
Copy link
Contributor Author

nLight commented Oct 9, 2018

@adityatandon007 you don't need a cluster for that. Just click into this /some/group-with-pods/podEFGH then Configuration tab - that's the same screen

@adityatandon007
Copy link

@nLight I got that but I want to ask that I am not able to see the network type and I know because the appConfig.networks might be null but then how can I get the name of the network.

screenshot from 2018-10-09 21-00-00

@adityatandon007
Copy link

@nLight I have added the Network Name under Networking but it still needs to call the function to get the name of the network like it is doing in case of Network Type but I can't get to output since I don't know what key it is to used to get the network name since my appConfig.networks is null. I know I'm almost there.
screenshot from 2018-10-09 21-08-10

@nLight
Copy link
Contributor Author

nLight commented Oct 9, 2018

Let me see...

@nLight
Copy link
Contributor Author

nLight commented Oct 9, 2018

Could you please create a work in progress PR?

@nLight
Copy link
Contributor Author

nLight commented Oct 26, 2018

It's in! Thank you for the effort! 🍁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants