Updated mesos package to use cmake. #7190

akornatskyy · 2020-04-13T14:40:23Z

High-level description

Build dcos linux mesos package with cmake.

Corresponding DC/OS tickets (required)

D2IQ-66807 build dcos linux mesos package with cmake.

d2iq-mergebot · 2020-04-13T14:40:26Z

This repo has @mesosphere-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@mesosphere-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.

@mesosphere-mergebot changelog-not-required reason 
@mesosphere-mergebot bump-ee  
@mesosphere-mergebot request-review  
@mesosphere-mergebot sync  
@mesosphere-mergebot override-status pr-status-check jira-url 
@mesosphere-mergebot backport  
@mesosphere-mergebot label [merge-by-mergebot|Ship It|Work In Progress|Request For Comment|dependencies|Ready For Review|do not merge - test|Holding] 
@mesosphere-mergebot merge-it

PR creators can apply one of [Ready For Review|Work In Progress]. Owners can apply any label.

d2iq-mergebot · 2020-04-13T14:40:26Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-13T14:40:55Z

Enterprise Bump PR: mesosphere/dcos-enterprise/pull/7733

d2iq-mergebot · 2020-04-14T14:54:50Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-14T14:55:19Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

d2iq-mergebot · 2020-04-15T15:12:05Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-15T15:12:07Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-16T09:16:41Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-16T09:16:43Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-16T11:39:09Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-16T11:39:12Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-16T15:59:13Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-16T15:59:16Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-17T06:35:49Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-17T06:36:21Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

d2iq-mergebot · 2020-04-17T09:27:55Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-17T09:28:21Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

d2iq-mergebot · 2020-04-21T08:13:12Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-21T08:13:14Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-21T10:32:17Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-21T10:32:47Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

d2iq-mergebot · 2020-04-21T11:46:20Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-21T11:46:50Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

d2iq-mergebot · 2020-04-22T13:35:52Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-22T13:35:54Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-23T09:13:57Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-04-23T09:14:00Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-04-23T14:08:00Z

@mesosphere-mergebot bump-ee

akornatskyy · 2020-05-29T12:27:37Z

@mesosphere-mergebot label Ready For Review

asekretenko · 2020-05-29T12:50:42Z

@akornatskyy note that the build the EE bump fails (the mergebot/enterprise/build-status/aggregate check below, also see the EE bump PR), because dcos-ee-mesos-modules still use the automake build.

Please incorporate your changes from
https://github.com/mesosphere/dcos-enterprise/pull/7843
into the EE bump PR created by mergebot
(https://github.com/mesosphere/dcos-enterprise/pull/7733, the link posted above by mesosphere-mergebot)

This is the case when we have to change OSS and EE together.

akornatskyy · 2020-05-29T13:12:38Z

@asekretenko done in https://github.com/mesosphere/dcos-enterprise/pull/7733

d2iq-mergebot · 2020-05-29T14:05:44Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-05-29T14:06:13Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

packages/mesos/build

d2iq-mergebot · 2020-05-29T15:19:54Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-05-29T15:20:24Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

packages/mesos/build

d2iq-mergebot · 2020-05-29T18:21:48Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-05-29T18:22:14Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

asekretenko

@akornatskyy Thanks for all this work!

If the remaining integration tests pass (I think now it is reasonable to hope that they will), the only thing that prevents us from merging this patch will be the Mesos bump that brings in the libprocess configuration fix that will resolve the failing memory profiler test.

After that bump gets into DCOS and if nothing else comes up, we (I/Greg/someone lese) will be able to land this PR pair.

akornatskyy · 2020-05-30T04:38:57Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-05-30T04:38:58Z

Your pull request's branch is not based on the most recent version of master. Please rebase your changes against this repo's master branch.

d2iq-mergebot · 2020-05-30T04:49:46Z

@mesosphere-mergebot bump-ee

d2iq-mergebot · 2020-05-30T04:50:16Z

Enterprise Bump mesosphere/dcos-enterprise/pull/7733 updated.

greggomann · 2020-06-01T17:37:15Z

@mesosphere-mergebot changelog-not-required No user-facing change.

d2iq-mergebot · 2020-06-01T17:37:17Z

CHANGES.MD check override issued with the provided reason: No user-facing change.

abudnik · 2020-06-17T13:35:51Z

packages/mesos/buildinfo.json

-    "git": "https://github.com/apache/mesos",
-    "ref": "3d68993c8743231b6067738050786e750edda9b1",
-    "ref_origin": "master"
+  "sources": {


Hey @akornatskyy @asekretenko ,
Do you happen to remember what was the reason to change this from single_source to sources? I'm asking because unfortunatelly it broke our 'Bump Mesos CI' script: https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/BumpDCOS/job/Bump_DCOS_Mesos_And_Modules/645/console

Does it make sense to change it back to single_source? Any concerns?

I don't see much sense for this change... but generally speaking using single_source should work as well. no concerns.

…ages. This patch reverts back changes made in PR dcos#7190.

…ages. This patch reverts back some changes made in PR dcos#7190.

d2iq-mergebot added the Work In Progress label Apr 13, 2020

akornatskyy force-pushed the cmake-linux branch from f70ea6d to 5aec4be Compare April 17, 2020 06:35

asekretenko reviewed May 29, 2020

View reviewed changes

packages/mesos/build Outdated Show resolved Hide resolved

asekretenko reviewed May 29, 2020

View reviewed changes

packages/mesos/build Show resolved Hide resolved

asekretenko previously approved these changes May 29, 2020

View reviewed changes

Updated mesos and mesos-modules packages to use cmake.

e318ce2

akornatskyy dismissed asekretenko’s stale review via e318ce2 May 30, 2020 04:49

akornatskyy force-pushed the cmake-linux branch from 92b5fbe to e318ce2 Compare May 30, 2020 04:49

greggomann approved these changes Jun 1, 2020

View reviewed changes

d2iq-mergebot added Ship It and removed Ready For Review labels Jun 1, 2020

d2iq-mergebot mentioned this pull request Jun 1, 2020

[master] Mergebot Automated Train PR - 2020-Jun-01-17-56 #7325

Merged

d2iq-mergebot merged commit 72554f3 into dcos:master Jun 1, 2020

abudnik reviewed Jun 17, 2020

View reviewed changes

abudnik added a commit to abudnik/dcos that referenced this pull request Jun 17, 2020

Reverted back to single_source for mesos and mesos-modules pack…

6a8a764

…ages. This patch reverts back changes made in PR dcos#7190.

abudnik added a commit to abudnik/dcos that referenced this pull request Jun 17, 2020

Reverted back to single_source for mesos and mesos-modules pack…

c9f0839

…ages. This patch reverts back some changes made in PR dcos#7190.

abudnik mentioned this pull request Jun 17, 2020

Reverted back to single_source for mesos and mesos-modules pack… #7384

Merged

Updated mesos package to use cmake. #7190

Updated mesos package to use cmake. #7190

Conversation

akornatskyy commented Apr 13, 2020 • edited

High-level description

Corresponding DC/OS tickets (required)

d2iq-mergebot commented Apr 13, 2020

d2iq-mergebot commented Apr 13, 2020

d2iq-mergebot commented Apr 13, 2020

d2iq-mergebot commented Apr 14, 2020

d2iq-mergebot commented Apr 14, 2020

d2iq-mergebot commented Apr 15, 2020

d2iq-mergebot commented Apr 15, 2020

d2iq-mergebot commented Apr 16, 2020

d2iq-mergebot commented Apr 16, 2020

d2iq-mergebot commented Apr 16, 2020

d2iq-mergebot commented Apr 16, 2020

d2iq-mergebot commented Apr 16, 2020

d2iq-mergebot commented Apr 16, 2020

d2iq-mergebot commented Apr 17, 2020

d2iq-mergebot commented Apr 17, 2020

d2iq-mergebot commented Apr 17, 2020

d2iq-mergebot commented Apr 17, 2020

d2iq-mergebot commented Apr 21, 2020

d2iq-mergebot commented Apr 21, 2020

d2iq-mergebot commented Apr 21, 2020

d2iq-mergebot commented Apr 21, 2020

d2iq-mergebot commented Apr 21, 2020

d2iq-mergebot commented Apr 21, 2020

d2iq-mergebot commented Apr 22, 2020

d2iq-mergebot commented Apr 22, 2020

d2iq-mergebot commented Apr 23, 2020

d2iq-mergebot commented Apr 23, 2020

d2iq-mergebot commented Apr 23, 2020

akornatskyy commented May 29, 2020

asekretenko commented May 29, 2020 • edited

akornatskyy commented May 29, 2020

d2iq-mergebot commented May 29, 2020

d2iq-mergebot commented May 29, 2020

d2iq-mergebot commented May 29, 2020

d2iq-mergebot commented May 29, 2020

d2iq-mergebot commented May 29, 2020

d2iq-mergebot commented May 29, 2020

asekretenko left a comment

Choose a reason for hiding this comment

akornatskyy commented May 30, 2020

d2iq-mergebot commented May 30, 2020

d2iq-mergebot commented May 30, 2020

d2iq-mergebot commented May 30, 2020

greggomann commented Jun 1, 2020

d2iq-mergebot commented Jun 1, 2020

abudnik Jun 17, 2020

Choose a reason for hiding this comment

akornatskyy Jun 17, 2020

Choose a reason for hiding this comment

akornatskyy commented Apr 13, 2020 •

edited

asekretenko commented May 29, 2020 •

edited