Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new feature for mahir #25

Closed
dcowden opened this issue Mar 22, 2018 · 7 comments
Closed

add new feature for mahir #25

dcowden opened this issue Mar 22, 2018 · 7 comments

Comments

@dcowden
Copy link
Owner

dcowden commented Mar 22, 2018

Just wrote this Round Emboss FS. It's an update to @neilcooke's Embossed Foot FS that supports non-planar surfaces and variable draft angle.
https://cad.onshape.com/documents/c906e2264d158509753b1bdb/w/54ac31d75d8897024a9c9c68/e/f07b5f8cd8f7543b972b1779

Creates round formed embosses with the specified height, diameter, and draft angle.

@takedownca
Copy link
Contributor

Revised description:

Creates round formed embosses with the specified height, diameter, and draft angle. Both planar and non-planar surfaces are supported.

@dcowden
Copy link
Owner Author

dcowden commented Mar 23, 2018

Got it, thanks. I'll get this added soon

@mbartlett21
Copy link
Collaborator

@dcowden @takedownca What section should this go in?

@dcowden
Copy link
Owner Author

dcowden commented Mar 23, 2018

from the existing categories,i'd recommend "Manufacturing and 3d Printing Features".

@mbartlett21
Copy link
Collaborator

mbartlett21 commented Mar 23, 2018

@dcowden
I didn't realise that when you make a commit and call it "fixes #(insert issue number)" it closes the issue.
😃 😄

@dcowden
Copy link
Owner Author

dcowden commented Mar 23, 2018

yah gitub is cool like that.

@mbartlett21
Copy link
Collaborator

@dcowden
That's the reason this got closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants