Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility #16

Merged
merged 4 commits into from Sep 24, 2014
Merged

Python 3 compatibility #16

merged 4 commits into from Sep 24, 2014

Conversation

dmr
Copy link
Contributor

@dmr dmr commented Sep 24, 2014

I changed a few lines to make logan python3 compatible:

  1. "print " --> "print("
  2. "except Exception, e" --> "except Exception as e"
  3. "raise ConfigurationError unicode(e), exc_info[2] " --> "raise ConfigurationError(unicode(e), exc_info[2])"
  4. iteritems --> items
  5. execfile is gone, I used http://stackoverflow.com/questions/436198/what-is-an-alternative-to-execfile-in-python-3-0

Also, I removed unittest2 because I couldn't get it to run in python3.

Do you like it? What can I improve?

@dcramer
Copy link
Owner

dcramer commented Sep 24, 2014

looks good, thanks!

dcramer added a commit that referenced this pull request Sep 24, 2014
@dcramer dcramer merged commit 16fcd81 into dcramer:master Sep 24, 2014
@dmr
Copy link
Contributor Author

dmr commented Sep 24, 2014

That was quick :)

@dmr
Copy link
Contributor Author

dmr commented Oct 7, 2014

Is Python3 support a reason to release a new version? What is missing for a release?

@khakulov
Copy link

Can you guys release this fix? I need it in my project.

@dmr
Copy link
Contributor Author

dmr commented Oct 29, 2014

Workaround:

pip install git+git://github.com/dcramer/logan.git@master#egg=logan -U

@csinchok csinchok mentioned this pull request Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants