Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing WASM PlutusScriptWitness constructor #297

Closed
solidsnakedev opened this issue Jan 9, 2024 · 5 comments · Fixed by #305
Closed

Missing WASM PlutusScriptWitness constructor #297

solidsnakedev opened this issue Jan 9, 2024 · 5 comments · Fixed by #305

Comments

@solidsnakedev
Copy link

CML 4.0.2
There's no way to instantiate a PartialPlutusWitness from PlutusScriptWitness, constructor is missing

class PlutusScriptWitness {

    static __wrap(ptr) {
        const obj = Object.create(PlutusScriptWitness.prototype);
        obj.ptr = ptr;
        PlutusScriptWitnessFinalization.register(obj, obj.ptr, obj);
        return obj;
    }

    __destroy_into_raw() {
        const ptr = this.ptr;
        this.ptr = 0;
        PlutusScriptWitnessFinalization.unregister(this);
        return ptr;
    }

    free() {
        const ptr = this.__destroy_into_raw();
        wasm.__wbg_plutusscriptwitness_free(ptr);
    }
    /**
    * @returns {ScriptHash}
    */
    hash() {
        const ret = wasm.plutusscriptwitness_hash(this.ptr);
        return ScriptHash.__wrap(ret);
    }
}
module.exports.PlutusScriptWitness = PlutusScriptWitness;
@rooooooooob
Copy link
Contributor

@solidsnakedev what about PartialPlutusWitness.new(script: PlutusScriptWitness, data: PlutusData)?

export class PartialPlutusWitness {
  free(): void;
/**
* @param {PlutusScriptWitness} script
* @param {PlutusData} data
* @returns {PartialPlutusWitness}
*/
  static new(script: PlutusScriptWitness, data: PlutusData): PartialPlutusWitness;
/**
* @returns {PlutusScriptWitness}
*/
  script(): PlutusScriptWitness;
/**
* @returns {PlutusData}
*/
  data(): PlutusData;
}

@solidsnakedev
Copy link
Author

solidsnakedev commented Feb 1, 2024

right but , how do I construct a PlutusScriptWitness class?

rooooooooob added a commit that referenced this issue Feb 1, 2024
Fixes #297

Adds missing conversions WASM API from PlutusScript to PlutusScriptWitness

Updates PlutusScript to include Plutus V3

Adds WASM PlutusV1/V2/V3Script to PlutusScript constructors

Missing wasm conversions for PlutusScript wasm<->rust
@rooooooooob
Copy link
Contributor

Ah sorry I misunderstood. I guess we missed it in the WASM ones since on the rust side it's via the From traits not as a method.

PR that resolves this: #305 (also a couple other missing script-related API I noticed).

Please let us know if you find anything else missing! Thanks for the report.

@solidsnakedev
Copy link
Author

thank you so much @rooooooooob :)

rooooooooob added a commit that referenced this issue Feb 1, 2024
Fixes #297

Adds missing conversions WASM API from PlutusScript to PlutusScriptWitness

Updates PlutusScript to include Plutus V3

Adds WASM PlutusV1/V2/V3Script to PlutusScript constructors

Missing wasm conversions for PlutusScript wasm<->rust
@rooooooooob
Copy link
Contributor

@solidsnakedev just fyi we released 5.1.0 a new version that includes this missing API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants