Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not add height and overflow styles to container if elementIsScrollable is false #50

Open
jinixx opened this issue Jul 31, 2018 · 1 comment

Comments

@jinixx
Copy link

jinixx commented Jul 31, 2018

If elementIsScrollable is false, the following shouldn't be added to the container, as scroll bar should be on the window itself, not container.

height: 100%; overflow: scroll;

@oscmedgon
Copy link

@jinixx Thats true I fixed this way I hope this hep you.
I added a simple class via classname to avoid overfllow.
I add this class name when the component receives the prop elementIsScrollable to false
className={this.props.className + ' ' + !elementIsScrollable && 'disable-scroll'}
And this scss code to remove the overflow

.redux-infinite-scroll  {
    &.disable-scroll {
        overflow: hidden !important;
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants