[Wii] Engine crashes on launch when loaded from USB with no SD card inserted

[Plombo]

It's in the title: OpenBOR on Wii can be loaded fine from a USB device if an SD card is inserted, but if no SD card is in the console, it crashes with a code dump on launch.

[msmalik681]

I have tested in every combination on latest build 6412 and it worked just fine !

Can you test wiiflow and see if it can load iso's from usb ?

[SieKensou]

I never had a SD inserted on the Wii when playing OpenBOR and I never noticed that problem, it loads fine.

[Plombo]

Okay, I've tested further and found the actual problem: the Gamecube controller adapter I have plugged in to the other USB port. Which causes a crash on startup only when launching from USB with no SD card inserted.

Launch from SD, GC controller adapter in USB port 2: no problem
Launch from USB, GC controller adapter in USB port 2, SD card inserted: no problem
Launch from USB, GC controller adapter in USB port 2, no SD card inserted: instant crash

[Plombo]

Unsurprisingly given the type of problem, it seems to be a libfat issue.

[msmalik681]

So usb works but in a very specific senario device conflict will cause a crash.

Do we have to leave this issue open as we have no control over libfat ?

[Plombo]

Feel free to unassign yourself from it, but I want to keep looking into this one. Every other Wii homebrew app works fine with this setup, so it is probably a problem with how we are using libfat.

[Wiimpathy]

It will also crash with other devices in port 1 like an usb keyboard for example. Adding a delay to be sure the drive is mounted should fix it. Here's how it's done in genesis plus gx:
https://github.com/ekeeke/Genesis-Plus-GX/blob/master/gx/main.c#L362
I don't have the GameCube adapter but you can test this dol if you want: http://www.mediafire.com/file/wzhw4w6swieamu0/Openbor-wii_plugin-fixes.zip/file

Not directly related but #58 has been closed and there's no solution right now. If you're interested, I've made a branch with argument's support and other small fixes here: https://github.com/Wiimpathy/openbor/commits/wii-plugin-and-fixes

In case you don't know what's this plugin system: https://sites.google.com/site/wiiflowiki4/plugins-setup

[Plombo]

Thank you, that is incredibly helpful!

[Plombo]

Oh, I didn't even notice you'd fixed it in your branch...

[dbaldan]

@Wiimpathy thanks for helping :)

[msmalik681]

So is this issue fixed now ?

[DCurrent]

@msmalik681 I believe so, but can't confirm.

[Plombo]

This has been fixed for a while. Forgot to close it.

[DCurrent]

Thanks @Plombo, I don't have a Wii to confirm.