Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two bugs encountered #2

Open
kaufManu opened this issue Oct 25, 2018 · 1 comment
Open

Two bugs encountered #2

kaufManu opened this issue Oct 25, 2018 · 1 comment

Comments

@kaufManu
Copy link

Great work - thanks a lot for this!

When using the code on some test images, I had to adjust the following pieces of code:

In Net.forward() after line 135 I added the statement

is_max = torch.unsqueeze(is_max, dim=0)

In Net.__init__() change line 79 to prevent a dimension mismatch as follows:

self.directional_filter.weight.data.copy_(torch.from_numpy(all_filters[:, None, ...]))
@DCurro
Copy link
Owner

DCurro commented Oct 26, 2018

I've taken your changes into consideration. This code was written in a very old version of PyTorch. I've updated to the newest version, and provided a pip requirements.txt file.

Thank you for letting me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants