Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AWS Route53 #422

Open
gsmlg opened this issue Jun 14, 2022 · 16 comments
Open

Add support for AWS Route53 #422

gsmlg opened this issue Jun 14, 2022 · 16 comments
Labels
enhancement New feature or request help-wanted There are no concrete plans to implement this but PRs are welcome. not-in-this-release Won't yet be handled in the upcoming release provider Adds, fixes or removes a provider.

Comments

@gsmlg
Copy link

gsmlg commented Jun 14, 2022

Add support for AWS Route53

@SuperSandro2000 SuperSandro2000 added enhancement New feature or request provider Adds, fixes or removes a provider. help-wanted There are no concrete plans to implement this but PRs are welcome. labels Jun 25, 2022
@fastalan
Copy link

There is a OpnSense plugin called dyndns that does this, the working code can be found here: https://github.com/opnsense/plugins/blob/master/dns/dyndns/src/etc/inc/plugins.inc.d/dyndns/phpDynDNS.inc

Just need someone to port his over, as that dyndns is about to be disabled.

@karlshea
Copy link

The issue is that dyndns uses a Route53 helper class that's like 700 lines of API request code.

That class probably does way more than it really needs to, but it's not as simple as just hitting a URL.

@fastalan
Copy link

The issue is that dyndns uses a Route53 helper class that's like 700 lines of API request code.

That class probably does way more than it really needs to, but it's not as simple as just hitting a URL.

Can’t we just use a perl module to do the same like this one?

https://metacpan.org/pod/Paws::Route53

@karlshea
Copy link

Is requiring another perl module acceptable to the maintainers? (paging @SuperSandro2000)

@SuperSandro2000
Copy link
Member

If we make it optional, sure why not. Less code to maintain in ddclient.

@karlshea
Copy link

I don't know Perl well enough to know if that's possible 😂

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Aug 5, 2022

I think you can load perl modules further down the code conditional which makes them optional. We should already be doing that somewhere.

@karlshea
Copy link

That package is insane... It's not just Paws::Route53, you have to use all of Paws which is some Perl AWS API monstrosity that isn't yet stable. I can't even tell from their docs how to configure it with an API key.

It would probably make more sense to write a helper that just updates zones, but as you can see in the helper function I linked above there's all sorts of XML conversion and signing that's going on, and I just don't know Perl well enough to dive in especially since my IP really doesn't change, so I'll just update zones myself whenever the old plugin stops working in OPNsense.

Gonna bow out of this one, sorry!

@fastalan
Copy link

This example seem much lighter, but is very old
https://github.com/mfontani/Net-Amazon-Route53

@g-psantos
Copy link

@SuperSandro2000 Pinging you in case you closed this by mistake: I couldn't find any PRs or commits to master indicating that support for Route 53 was implemented.

@karlshea
Copy link

It won't be, see #528

@SuperSandro2000
Copy link
Member

Unless someone creates a PR for it, it will not happen.

@issmirnov
Copy link

@LenardHess I saw on #528 (comment) that you have taken ownership - thank you!

Is there a chance of this Feature Request being re-opened? I unfortunately don't have the cycles to help with coding this up, but would be very happy to beta test and post logs + debug as needed.

Thank you!

@LenardHess
Copy link
Contributor

I'll reopen it with 'help-wanted', but will probably not tackle it too quickly if at all. For now I want to get maintenance stabilized, new releases out etc.

@LenardHess LenardHess reopened this Aug 2, 2023
@LenardHess LenardHess added the not-in-this-release Won't yet be handled in the upcoming release label Aug 2, 2023
@shafferchance-lulu
Copy link

Hey, I started work on this issue Friday (9/08/23). I got the signature working without anything outside of the core Perl modules. Going to get the other logic finished up here and make a PR within the next two days. Formulating the signature isn't too bad, however, I don't program in Perl really so please provide me with some guidance once things are posted.

@shafferchance
Copy link

Only like 4 months late, but better late than never got caught up with real life. Thank you all for the support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help-wanted There are no concrete plans to implement this but PRs are welcome. not-in-this-release Won't yet be handled in the upcoming release provider Adds, fixes or removes a provider.
Projects
None yet
Development

No branches or pull requests

9 participants