Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency cycles between patron and book #23

Closed
bslota opened this issue Apr 9, 2019 · 3 comments
Closed

Dependency cycles between patron and book #23

bslota opened this issue Apr 9, 2019 · 3 comments

Comments

@bslota
Copy link
Collaborator

bslota commented Apr 9, 2019

There are dependency cycles between patron and book packages.

image

Problematic dependencies include: events, PatronId, book types
@ghost
Copy link

ghost commented Apr 17, 2019

@bslota Because book has holds by some patron and patron can hold any book. So, this dependency cycle is implicit by requirement, no?

Explain me please if I misunderstood.

@ghost
Copy link

ghost commented Apr 17, 2019 •
edited by ghost

Also, this ticket is workings of #19

@bslota
Copy link
Collaborator Author

bslota commented Apr 18, 2019

Duplicate of #19

@dosdebug you're right. I'm closing the issue. We will move the discussion there.

@bslota bslota closed this as completed Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bslota