Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding problem with 1.7 #405

Closed
pyatnitsev opened this issue Mar 18, 2019 · 3 comments
Closed

Encoding problem with 1.7 #405

pyatnitsev opened this issue Mar 18, 2019 · 3 comments
Labels

Comments

@pyatnitsev
Copy link
Contributor

pyatnitsev commented Mar 18, 2019

Hi!

Recent changes of version 1.7 has break down work with outlook mailboxes.

4ac25b7

In method getMessages you are add an string parameter encoding, that not completely right, becouse imap_search by default accept NULL as encoding and it can't be override in your case,

I suggest to change default encoding to null and type hit to ?string insted of string.
and after it do this check:

if encoding not null -> pass it to imap_search or not pass otherwise

@Slamdunk
Copy link
Collaborator

May you test #406 branch and tell me if this solves the bug?

@pyatnitsev
Copy link
Contributor Author

@Slamdunk, thanks for your patch!
I just tested it on my mailbox - it works fine for me

@Slamdunk
Copy link
Collaborator

Fix released in 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants