Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev config overrides TYPO3 AdditionalConfiguration.php when no LocalConfiguration.php found #1053

Closed
ulrichmathes opened this issue Aug 15, 2018 · 3 comments
Milestone

Comments

@ulrichmathes
Copy link

The documentation says that AdditionalConfiguration.php will only be modified if file does not exists or is managed by DDEV.

For TYPO3, DDEV settings are written to AdditionalConfiguration.php. If AdditionalConfiguration.php exists and is not managed by DDEV, it will not be modified.

This is not true for ddev config when TYPO3 is has been set up

Hint in ddev config about this behavior:

TYPO3 does not seem to have been set up yet, missing LocalConfiguration.php ([...]/public/typo3conf/AdditionalConfiguration.php)

To Reproduce
Steps to reproduce the behavior:

  1. composer create-project typo3/cms-base-distribution my-typo3-site ^8
  2. cd my-typo3-site
  3. echo "<?php" > public/typo3conf/AdditionalConfiguration.php
  4. ddev config

Expected behavior
AdditionalConfiguration.php should not be modified.

Version and configuration information:

  • Host computer OS and Version: Linux
  • Docker version: 18.06.0-ce
  • ddev version information:

cli v1.0.0
web drud/ddev-webserver:v1.0.0
db drud/ddev-dbserver:v1.0.0
dba drud/phpmyadmin:v1.0.0
router drud/ddev-router:v1.0.0
commit v1.0.0
domain ddev.local

  • config.yaml:
type: typo3
docroot: public
php_version: "7.2"
router_http_port: "80"
router_https_port: "443"
xdebug_enabled: false
additional_hostnames: []
additional_fqdns: []
provider: default
@rfay
Copy link
Member

rfay commented Aug 15, 2018

I can recreate this and agree that this isn't the expected behavior, although it does seem unlikely to have an unmanaged AdditionalConfiguration.php and no LocalConfiguration.php. I'll put this into our next sprint.

@rfay rfay added this to the v1.2.0 milestone Aug 15, 2018
@ulrichmathes
Copy link
Author

Great.

Explanation why i need this: I'm recreating the boilerplate for our TYPO3 projects using ddev. There we have dotenv configurations within the AdditionalConfiguration.php but TYPO3 is not installed yet (no LocalConfiguration.php) before calling ddev config.

@rfay
Copy link
Member

rfay commented Aug 15, 2018

I'm sure you know that ddev will not be able to add any of its own config if you do that, but I'm sure you've got that covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants