Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ddev config flag input values #1095

Closed
andrewfrench opened this issue Aug 31, 2018 · 0 comments
Closed

Validate ddev config flag input values #1095

andrewfrench opened this issue Aug 31, 2018 · 0 comments
Assignees
Milestone

Comments

@andrewfrench
Copy link
Contributor

The Issue
In #1092, support for defining config values can through flags passed into ddev config was added, but these values are currently naively written to config.yaml without any validation. There are several instances where providing wrong values might lead to cryptic error messages at the container or application level, but we can do basic validation on the values before accepting and writing them.

The Solution
Validate values passed into ddev config flags before writing config.yaml. In some cases, like PHP versions, one source of truth should be defined to indicate which values are supported and valid config values. In other cases, like FQDNs and hostnames, basic string validation can be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants