Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve project start/stop performance by not always restarting ddev-router #1236

Closed
rfay opened this issue Oct 30, 2018 · 2 comments
Closed

Comments

@rfay
Copy link
Member

rfay commented Oct 30, 2018

Describe the bug

ddev-router is currently stopped and started for every ddev start. At least one reason for this is that the required ports may change when a new project is started. We can save a couple of seconds on every start by not doing that if the router is already going.

We can at least work around that precalculating the total router ports, perhaps maintaining them as docker labels. Alternately, this could b e the time to introduce global status, but I don't think so.

@dclear dclear added the OKR label Oct 30, 2018
@mglaman
Copy link
Contributor

mglaman commented Nov 1, 2018

One thing I would like to mention: I dislike the fact that Lando does not kill its router/proxy when all projects are stopped. You get stuck with a forever running landoproxyhyperion5000gandalfedition_proxy_1 container, which is pretty annoying.

I like the idea of ddev-router not having to be restarted whenever I start a second or third project. But if I run ddev stop and no other projects are running, I'd like the router to shut down.

@rfay
Copy link
Member Author

rfay commented Nov 1, 2018

We don't have any plans to change the current behavior, where turning off the last project stops the router. OTOH, the new ddev-ssh-agent will persist, as otherwise people would have to re-enter their passphrase, so the intention is it will persist until turned off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants