-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddev should support bash autocomplete #125
Comments
I'm in favor of this. What's the LOE (or is there a decent reference article) to achieve this? |
According to https://github.com/spf13/cobra Cobra (the package we use for argument handling) provides
So I guess we just have to install it for the user? |
I started down the path of writing bash/zsh tab completion for the drud command line tool. If we can enable this via cobra it would significantly increase maintainability. |
Bump. Worth prioritizing? |
Way worth it to me! |
@cyberswat I know you're getting more time in the issue queue. Is this something you'd like to tackle for v0.8? |
Sure thing. I poked at this a bit in the traditional way before we figured out that it was something cobra would provide. |
@rickmanelius I think it makes sense to get this assigned to another developer. There are some great resources out there to get started with including https://github.com/spf13/cobra/blob/master/bash_completions.go and https://github.com/spf13/cobra/blob/master/bash_completions.md. Let's get this reassigned. |
Cobra does not yet directly support zsh, but it might before long (spf13/cobra#107) Kubernetes took their own route and wrote a separate zsh completion generator but I don't really see the value of doing that and then maintaining the code. Would it be OK to change this issue to support bash only at this point? |
Bash is better than nothing! |
I guess that was a thumbs-up so I'll change the title and OP. |
What happened (or feature request):
ddev doesn't currently seem to support bash/zsh autocomplete. But everybody else does :)
What you expected to happen:
I expect to be able to hit tab and get autocomplete suggestions.
How to reproduce it (as minimally and precisely as possible):
Type
ddev
and hit tab.Anything else do we need to know:
At the time this ticket is being addressed, spf13 does not directly support zsh autocomplete, although they're (maybe) working on it. Kube implemented it separately.
The strategy here will be to do bash autocomplete now and monitor the zsh issue, spf13/cobra#107
Related source links or issues (like source JIRA issue):
The text was updated successfully, but these errors were encountered: