Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev should support bash autocomplete #125

Closed
rfay opened this issue Apr 5, 2017 · 11 comments
Closed

ddev should support bash autocomplete #125

rfay opened this issue Apr 5, 2017 · 11 comments
Assignees
Milestone

Comments

@rfay
Copy link
Member

rfay commented Apr 5, 2017

What happened (or feature request):

ddev doesn't currently seem to support bash/zsh autocomplete. But everybody else does :)

What you expected to happen:

I expect to be able to hit tab and get autocomplete suggestions.

How to reproduce it (as minimally and precisely as possible):

Type ddev and hit tab.

Anything else do we need to know:

At the time this ticket is being addressed, spf13 does not directly support zsh autocomplete, although they're (maybe) working on it. Kube implemented it separately.

The strategy here will be to do bash autocomplete now and monitor the zsh issue, spf13/cobra#107

Related source links or issues (like source JIRA issue):

@rickmanelius
Copy link
Contributor

I'm in favor of this. What's the LOE (or is there a decent reference article) to achieve this?

@rfay
Copy link
Member Author

rfay commented Apr 12, 2017

According to https://github.com/spf13/cobra Cobra (the package we use for argument handling) provides

Automatically generated bash autocomplete for your application

So I guess we just have to install it for the user?

@cyberswat
Copy link
Contributor

I started down the path of writing bash/zsh tab completion for the drud command line tool. If we can enable this via cobra it would significantly increase maintainability.

@rickmanelius
Copy link
Contributor

Bump. Worth prioritizing?

@rfay
Copy link
Member Author

rfay commented Jun 1, 2017

Way worth it to me!

@rickmanelius rickmanelius added this to the v1.0 milestone Jun 6, 2017
@rickmanelius
Copy link
Contributor

@cyberswat I know you're getting more time in the issue queue. Is this something you'd like to tackle for v0.8?

@rickmanelius rickmanelius modified the milestones: v0.8, v1.0 Jun 6, 2017
@cyberswat
Copy link
Contributor

Sure thing. I poked at this a bit in the traditional way before we figured out that it was something cobra would provide.

@cyberswat cyberswat self-assigned this Jun 6, 2017
@rfay rfay added actionable and removed incubate labels Jun 8, 2017
@cyberswat
Copy link
Contributor

@rickmanelius I think it makes sense to get this assigned to another developer. There are some great resources out there to get started with including https://github.com/spf13/cobra/blob/master/bash_completions.go and https://github.com/spf13/cobra/blob/master/bash_completions.md. Let's get this reassigned.

@rfay rfay assigned rfay and unassigned cyberswat Jun 12, 2017
@rfay
Copy link
Member Author

rfay commented Jun 12, 2017

Cobra does not yet directly support zsh, but it might before long (spf13/cobra#107)

Kubernetes took their own route and wrote a separate zsh completion generator but I don't really see the value of doing that and then maintaining the code.

Would it be OK to change this issue to support bash only at this point?

@rickmanelius
Copy link
Contributor

Bash is better than nothing!

@rfay
Copy link
Member Author

rfay commented Jun 13, 2017

I guess that was a thumbs-up so I'll change the title and OP.

@rfay rfay changed the title ddev should support bash/zsh autocomplete ddev should support bash autocomplete Jun 13, 2017
@rfay rfay closed this as completed in 67268ed Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants