Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wordpress wpskeleton ddev composer create deprecation warning about package name, composer.json #1879

Closed
rfay opened this issue Oct 10, 2019 · 2 comments

Comments

@rfay
Copy link
Member

rfay commented Oct 10, 2019

Describe the bug

The first relevant line of a composer.json created by ddev composer create looks like this:

"name": "vendor/.tmp_ddev_composer_create_fldfwf"

Composer complains quite a lot about this, saying that that 'package name' will be invalid in 2.0.

Deprecation warning: Your package name vendor/.tmp_ddev_composer_create_fldfwf is invalid, it should have a vendor name, a forward slash, and a package name. The vendor and package name can be words separated by -, . or _. The complete name should match "a-z0-9/a-z0-9". Make sure you fix this as Composer 2.0 will error.

But the reality is that "name" is naturally the 2nd part of the package name. For example, if the package is "wordpress/skeleton", the "name" will be "skeleton"

My bet is that we need to composer create-project into its own directory named for the top-level package (the natural way)

To Reproduce

ddev composer create wordpress/skeleton --no-install
ddev composer install

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Version and configuration information (please complete the following information):

  • Host computer OS and Version: [e.g. Windows 10, macOS High Sierra]
  • Docker version information (use docker version) and insert it here.
  • ddev version information (use ddev version)
  • config.yaml contents for the misbehaving project
  • Do you have any custom configuration (nginx, php, mysql) in the .ddev folder? If so, have you tried without them?

Additional context
Add any other context about the problem here. Thanks!

@rfay rfay changed the title ddev composer create makes an incompatible name in composer.json ddev composer create deprecation warning about package name, composer.json Oct 10, 2019
@rfay
Copy link
Member Author

rfay commented Oct 23, 2019

The weird thing is it shouldn't be creating anything in vendor folder. I'm looking forward to spending some time with wpskeleton...

@rfay rfay changed the title ddev composer create deprecation warning about package name, composer.json Wordpress wpskeleton ddev composer create deprecation warning about package name, composer.json Oct 23, 2019
@rfay
Copy link
Member Author

rfay commented Nov 13, 2019

#1928 points out that wordpress/skeleton isn't really maintained and doesn't work right at all anyway, so not going to spend effort on this one.

@rfay rfay closed this as completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant