Codespaces changed preview domain to app.github.dev (ddev launch fails)

[mandrasch]

Is there an existing issue for this?

• I have searched the existing issues

Output of ddev debug test

No response

Expected Behavior

• ddev launch works in codespaces ddev project, e.g. craftcms project

Actual Behavior

• url not found since github changed codespaces url, see below

Steps To Reproduce

No response

Anything else?

Codespaces changed their port forwarding domain:

To prepare for this change, replace any hardcoded references to preview.app.github.dev in your code with the GITHUB_CODESPACES_PORT_FORWARDING_DOMAIN environment variable by July 31 to avoid any disruptions. The environment variable value will be updated from preview.app.github.dev to app.github.dev when the migration completes. Learn more about environments variables here.

https://github.blog/changelog/2023-07-14-codespaces-port-forwarding-domain-name-updates/

Hardcoded here:

• ddev/pkg/ddevapp/ddevapp.go

  Lines 2545 to 2546 in ef44484

  	url := fmt.Sprintf("https://%s-%s.preview.app.github.dev", codespaceName, app.HostWebserverPort)
  	httpsURLs = append(httpsURLs, url)

(Currently I don't have time resources to change and test this myself and provide a quick PR. Hope that I can provide such small fixes in future by myself (need to learn the whole workflow how to test that ddev still works after my changes 😬 😉 ))

[rfay]

Thanks! This one you could probably just do with the edit button on github, it's welcome. And testing might be as easy as downloading the artifacts from the PR page and running them on Codespaces.

[rfay]

This was fixed in

• fix: change codespaces forwarding domain name to app.github.dev  #5257