Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No validation when running ddev start project-name #5445

Closed
1 task done
stasadev opened this issue Oct 23, 2023 · 1 comment
Closed
1 task done

No validation when running ddev start project-name #5445

stasadev opened this issue Oct 23, 2023 · 1 comment

Comments

@stasadev
Copy link
Member

stasadev commented Oct 23, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior

When you run ddev start project-name, and you have some invalid config, DDEV should be stopped early.

Actual Behavior

When you have some invalid config, DDEV runs some checks on ddev start, but there are no checks when you run ddev start project-name, and project continues to start.

Steps To Reproduce

  1. mkdir start-validation && cd start-validation && ddev config --auto
  2. open .ddev/config.yaml and make some invalid change, I did php_version: "9.0"
  3. ddev start
  4. see an error as it should be:
$ ddev start
Failed to get project(s): unsupported PHP version: 9.0, DDEV only supports the following versions: [5.6 7.0 7.1 7.2 7.3 7.4 8.0 8.1 8.2 8.3]
  1. ddev start start-validation
  2. see this:
$ ddev start start-validation
Starting start-validation... 
 Container ddev-ssh-agent  Created 
 Container ddev-ssh-agent  Started 
ssh-agent container is running: If you want to add authentication to the ssh-agent container, run 'ddev auth ssh' to enable your keys. 
Building project images... 
Project images built in 3s. 
 Network ddev-start-validation_default  Created 
 Container ddev-start-validation-web  Created 
 Container ddev-start-validation-db  Created 
 Container ddev-start-validation-db  Started 
 Container ddev-start-validation-web  Started 
Waiting for web/db containers to become ready: [web db] 
Failed waiting for web/db containers to become ready: web container failed: log=, err=container exited, please use 'ddev logs -s web' to find out why it failed 
Something is wrong with Docker or Colima and /mnt/ddev_config is not mounted from the project .ddev folder. This can cause all kinds of problems. 
Starting ddev-router if necessary... 
 Container ddev-router  Created 
 Container ddev-router  Started 
Waiting for additional project containers to become ready... 
Failed to start start-validation: container(s) failed to become healthy before their configured timeout or in 120 seconds. This might be a problem with the healthcheck and not a functional problem. (container 'web' exited, please use 'ddev logs -s web' to find out why it failed)

Anything else?

I believe this can be caused when you upgrade an old DDEV to a new one with old configs and start a project with ddev start project-name and see that it fails without any explanation

@rfay
Copy link
Member

rfay commented Oct 23, 2023

Good catch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants