New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to use project_list.yaml exclusively for project list #5918
Comments
/cc @GuySartorelli - would love it if you wanted to take this on. |
I agree that this should be done at some point, but it may be too soon. If people upgrade from v1.22.7 to v1.23.0, everything will be fine. As far as I understand, the list of projects will be lost if people upgrade from v1.22.6 and earlier to v1.23.0. This requires more planning. |
Right now we have some confusion in support when people have complex problems and need to delete a project manually. They have to do it two places. This has even confused me a couple of times. We may need to go ahead and do it now. As you know, when people lose the list for whatever reason, it's fixed with a |
I'd recommend still pulling from the global config if it's there for another release or two - but not saving the content into the global config. So the prject list yaml file becomes the source of truth, but anyone updating from an older version of DDEV won't experience any issues. |
That sounds like a separate issue tbh. I'd be happy to work on the separation between project list and global config, but I don't want to touch the other stuff. |
I think we should separate, would love to have you go ahead with it. I agree with @stasadev that it's not perfect timing, but the current situation is causing confusion already, so I think it's time to move on. |
And I agree that moving the other two items is a separate task, to be considered separately. It's just the same general class of problem as the project list was. |
Just to be really clear, when you say "I think we should separate" and "I think it's time to move on" do you mean let's not read from global config at all anymore for the project list (which could cause upgrade pains)? Or do you mean just don't store to global config anymore (this will resolve the confusion without causing upgrade pains)? |
I mean "project list should no longer be in global_config.yaml and should be exclusively in project_list.yaml" |
We're all in agreement about that, but that still doesn't answer the main question. I'll try phrasing it differently. |
Pulling in the project list from global_config.yaml on upgrade from a version that does not have a project_list.yaml is a great idea. This could probably be done in FixObsolete(). |
I keep forgetting |
Actually looking at the code flow I think that's the wrong place for this. I've opened #5926 to handle this issue. It pulls in the project list from |
Expected Behavior
We don't want duplicates of project list
In
the ~/.ddev/project_list.yaml approach was created, but it duplicates ~/.ddev/global_config.yaml
Now sometimes people try to delete from one and can't sort out problems they find.
Another thing to take a look at is whether we want to move anything else out of ~/.ddev/global_config.yaml.
Things that aren't really config items but actually managed by DDEV:
The text was updated successfully, but these errors were encountered: