Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddev-webserver healthcheck should exit early on error with apache/nginx/php-fpm #5993

Closed
1 task done
stasadev opened this issue Mar 20, 2024 · 1 comment
Closed
1 task done
Milestone

Comments

@stasadev
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Output of ddev debug test

Expand `ddev debug test` diagnostic information
[COPY-PASTE HERE THE OUTPUT OF `ddev debug test`]

Expected Behavior

The user should not wait two minutes for a timeout if something goes wrong with apache/nginx/php-fpm

Actual Behavior

If the container fails to become healthy on ddev start, the supervisor tries to restart apache/nginx/php-fpm until the 2 minute timeout. Previously, this led to early failure, but now we have a timeout.

The logic changed after

Steps To Reproduce

See:

Anything else?

The issue is partially discussed in:

@stasadev stasadev added this to the v1.23.0 milestone Mar 20, 2024
@rfay
Copy link
Member

rfay commented Mar 20, 2024

Thanks for opening the issue!

@rfay rfay changed the title Docker healthcheck should exit early on error with apache/nginx/php-fpm ddev-webserver healthcheck should exit early on error with apache/nginx/php-fpm Mar 20, 2024
@rfay rfay closed this as completed in 7f2d79b Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants