Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project type is being reconfigured to PHP if config is run before composer install #6044

Closed
1 task done
justafish opened this issue Apr 3, 2024 · 2 comments
Closed
1 task done

Comments

@justafish
Copy link
Contributor

justafish commented Apr 3, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Expected Behavior

When checking out a new project with type: drupal10 (or lower), and something like this is run before composer install:

❯ ddev config --web-environment-add="COMPOSER_CACHE_DIR=/var/www/html/.ddev/.drainpipe-composer-cache"
You are reconfiguring the project at /home/justafish/repos/site.com
The existing configuration will be updated and replaced.
A project of type 'php' was found in /home/justafish/repos/site.com/web, but the project is configured with type 'drupal10'
Configuring a 'php' project with docroot 'web' at /home/justafish/repos/site.com/web
Configuration complete. You may now run 'ddev start'.

This is causing jobs using Drainpipe's DDEV action to fail. Example workflow here: Lullabot/drainpipe#512

Actual Behavior

This is happening because when detecting the project type it's looking for a file that isn't necessarily present yet:

f := filepath.Join(app.AppRoot, app.Docroot, "core/lib/Drupal.php")

@stasadev
Copy link
Member

stasadev commented Apr 3, 2024

Already fixed in (will be available in DDEV v1.23.0):

BTW, your GitHub action uses an old repo link. It works, but it's better to update it to the latest one.

@stasadev stasadev closed this as completed Apr 3, 2024
@rfay
Copy link
Member

rfay commented Apr 3, 2024

DDEV v1.23.0-alpha1 is already available, and we'll have an RC in a couple of days. Please do update the installation technique as @stasadev says, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants